Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on sqlx #1

Closed
danilobuerger opened this issue Feb 8, 2017 · 4 comments
Closed

Dependency on sqlx #1

danilobuerger opened this issue Feb 8, 2017 · 4 comments
Assignees

Comments

@danilobuerger
Copy link
Member

Apart from legacy, is there a reason we have to depend on sqlx? If not, I would tackle removing it on the weekend.

@gravis
Copy link
Member

gravis commented Feb 8, 2017

I just find the code easier to read and write.
On the contrary, is there a good reason for not using it?
Check out gemnasium/migrate@a4fb341#diff-1cf6273eb48ed6deda1dce6b0c75f94aR142
IMHO, database/sql is more intended for low level things.

@danilobuerger
Copy link
Member Author

It's just one more dependency a user has to pull in. Not everybody is using sqlx in their project, so they would have that dependency only for the migration part.

Really the only thing that would change is the select in func (driver *Driver) Versions() (file.Versions, error). So it's a tradeoff between 10 more LOCs vs. pulling in a whole library that depends on even more reflection to get the job done.

@gravis
Copy link
Member

gravis commented Feb 8, 2017

Understood. Ok, go for it then.
Thanks!

@danilobuerger danilobuerger self-assigned this Feb 8, 2017
@danilobuerger
Copy link
Member Author

Will do on the weekend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants