Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug where already-quoted search path components could get double-quoted when creating the migrations table. #47

Merged
merged 1 commit into from
Sep 10, 2023
Merged

Fix bug where already-quoted search path components could get double-quoted when creating the migrations table. #47

merged 1 commit into from
Sep 10, 2023

Commits on Dec 25, 2019

  1. fix(createMigrationsTable): Fix bug where already-quoted search path … 

    …components could get double-quoted when creating the mirations table.

Postgres's `SHOW search_path` returns the search path as a comma-separated string with spaces, like `"$user", public, "another-quoted-schema"`, so checking whether the _first character_ of a search path component is `"` is not sufficient. Instead, just check whether the search path component contains quotes at all, and don't add any quotes if it does.

Signed-off-by: Girffin Schneider <griffinschneider@gmail.com>
    @GriffinSchneider
    GriffinSchneider committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    79436f3 View commit details
    Browse the repository at this point in the history