Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add sa11y to showcases to find some a11y issues #2646

Merged
merged 2 commits into from
May 16, 2024
Merged

Conversation

nmerget
Copy link
Member

@nmerget nmerget commented May 15, 2024

Proposed changes

part of #2579

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@nmerget nmerget enabled auto-merge (squash) May 15, 2024 11:12
@github-actions github-actions bot added the 📺showcases Changes to 1-n showcases label May 15, 2024
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/test-sa11y

@mfranzke
Copy link
Member

what's your impression, could this add any value besides what we already have by axe? Did you have any reportings that mentioned further aspects?

@nmerget
Copy link
Member Author

nmerget commented May 16, 2024

Yes, there are some minor findings for the showcases. I guess it's working better for a "real" app with more content, but besides this we have some additional settings like the color-contrast (which isn't working at the moment because of an issue with color-mix).

@nmerget nmerget merged commit 8d7105c into main May 16, 2024
37 checks passed
@nmerget nmerget deleted the test-sa11y branch May 16, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📺showcases Changes to 1-n showcases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants