fix test_until_time failure when run early #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since introduction of the "until" job scheduling method to apply deadlines, the test suite fails at test_until_time when run between midnight and 5am local hour. This patch ought to ensure the deadline is always one hour ago independently of the time of the day, or night. This should resolve Github issue dbader#488. Signed-off-by: Étienne Mollier <emollier@debian.org>
|
Thank you so much for this pr! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since introduction of the "until" job scheduling method to apply deadlines, the test suite fails at test_until_time when run between midnight and 5am local hour. This patch ought to ensure the deadline is always one hour ago independently of the time of the day, or night. This should resolve Github issue #488.