-
Notifications
You must be signed in to change notification settings - Fork 961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_until_time failing since 1.1.0 #488
Comments
It is flaky it seems. |
given that this fails at, say, 4am localtime, and editing that hour=5 to hour=3 makes it pass instantly, and editing it back to =5 makes it consistently fail, i assume that is just setting current_date.hour, and so it is not 'in the past' as what it tries to test, and so doesn't fail as it's not invalid to schedule something just slightly in the future from localtime. i could also be misunderstanding what it means, but based on the behaviour it seems to explain why it fails at a certain time of day |
Since introduction of the "until" job scheduling method to apply deadlines, the test suite fails at test_until_time when run between midnight and 5am local hour. This patch ought to ensure the deadline is always one hour ago independently of the time of the day, or night. This should resolve Github issue dbader#488. Signed-off-by: Étienne Mollier <emollier@debian.org>
This has been resolved in #563. Thanks to everyone here for reporting and debugging! 🚀 |
After upgrading to 1.1.0 we see the following test fail:
It was introduced in 1849e01.
The text was updated successfully, but these errors were encountered: