Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a Durandal skeleton to the registry. #1

Merged
merged 3 commits into from
Jan 25, 2013
Merged

Added a Durandal skeleton to the registry. #1

merged 3 commits into from
Jan 25, 2013

Conversation

EisenbergEffect
Copy link
Contributor

Congratulations! Your first real skeleton! I'll probably be updating it a bit in the next couple of weeks, but wanted to go ahead and get the first real, working version registered so I can start using it myself. Eagerly awaiting a merge :)

@dbashford
Copy link
Owner

Lets pretend someday there are 100 skeletons and someone doesn't have time to look at every one. mimosa skel:search knockout ideally should return durandal, yeah? Maybe worth mentioning that in the keywords list along with any other key wrapped technologies?

Also, "mimosa", "skeleton" are not worth mentioning. Those are a given and I just have them in the test entry for testing purposes.

@EisenbergEffect
Copy link
Contributor Author

Yeah. I should have thought of that. Let me update it real quick....

On Fri, Jan 25, 2013 at 11:16 AM, dbashford notifications@github.comwrote:

Lets pretend someday there are 100 skeletons and someone doesn't have time
to look at every one. mimosa skel:search knockout ideally should return
durandal, yeah? Maybe worth mentioning that in the keywords list along with
any other key wrapped technologies?

Also, "mimosa", "skeleton" are not worth mentioning. Those are a given and
I just have them in the test entry for testing purposes.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-12707587.

Rob Eisenberg,
Blue Spire Consulting, Inc.
Caliburn Project
850.264.3996

@EisenbergEffect
Copy link
Contributor Author

Wait...one more thing.

@dbashford
Copy link
Owner

I still intend to bastardize some skeletons from other frameworks for inclusion, probably some simple backbone stuff since its what I am comfy with. Once I've done that I'll toss this module in as a default mimosa module. Until then, someone will need to specifically mimosa mod:install mimosa-skeleton to use your skeleton.

@EisenbergEffect
Copy link
Contributor Author

Sounds good.

On Fri, Jan 25, 2013 at 11:24 AM, dbashford notifications@github.comwrote:

I still intend to bastardize some skeletons from other frameworks for
inclusion, probably some simple backbone stuff since its what I am comfy
with. Once I've done that I'll toss this module in as a default mimosa
module. Until then, someone will need to specifically mimosa mod:install
mimosa-skeleton to use your skeleton.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-12707961.

Rob Eisenberg,
Blue Spire Consulting, Inc.
Caliburn Project
850.264.3996

@EisenbergEffect
Copy link
Contributor Author

Ok. I got it where I want it I think.

@dbashford
Copy link
Owner

Will merge this now...

On your mimosa-config (purely nit picks, feel free to disregard me!)

  • You should be able to remove the watch.sourceDir config setting as it is the default. Welcome to keep it obviously, no big deal to me, I just love to see tinytiny config. =)
  • Copy extensions. You've added some and removed some. I'd be happy to add some of those that you added as defaults. So if the removal of the ones ones you removed isn't vital, once I've added those to the default, theoretically you could remove that config as well.
  • Might be worth adding a minMimosaVersion, minMimosaVersion:"0.8.7". Can bump it whenever I make any breaking changes and you make any necessary updates.

Thanks again! Stoked to have my first skeleton!

dbashford added a commit that referenced this pull request Jan 25, 2013
Added a Durandal skeleton to the registry.
@dbashford dbashford merged commit b60a2ec into dbashford:master Jan 25, 2013
@EisenbergEffect
Copy link
Contributor Author

Thanks for the feedback. I made all the recommended improvements as well as another fix I found. Ultimately, I will need to write a custom module for mimosa. I'll try to make that happen next week. How do I register it so that the mimosa config find it? Is it just a git repo naming convention?

@dbashford
Copy link
Owner

I currently don't provide a means to load a module from a git repo. Just locally and via NPM. Worth publishing it to NPM?

And will my providing an overrides function keep you from needing to create the module?

@EisenbergEffect
Copy link
Contributor Author

Well, I think it's better for me to create the module because...I think
there's a potential for lots of modules to not be picked up. So, I could
definitely publish the module to npm. I've never done that before...but
there's a first time for everything. I'll read through
http://mimosajs.com/modules.html and see if I have any questions.

On Fri, Jan 25, 2013 at 12:49 PM, dbashford notifications@github.comwrote:

I currently don't provide a means to load a module from a git repo. Just
locally and via NPM. Worth publishing it to NPM?

And will my providing an overrides function keep you from needing to
create the module?


Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-12712276.

Rob Eisenberg,
Blue Spire Consulting, Inc.
Caliburn Project
850.264.3996

@dbashford
Copy link
Owner

Publishing to NPM is a piece of cake. When you create the skeleton (mimosa mod:init <name of skeleton> optional -c flag if you want to write it in coffeescript) it'll drop a package.json in for you. You'll have a few placeholders to edit inside of it, but other than that it'll just be the few steps to get yourself added to npm. You can check out any of the existing modules for packaging examples.

@EisenbergEffect
Copy link
Contributor Author

Excellent. I'll probably be using the text plugin module as a template,
since it's very close to what I want to do.

On Fri, Jan 25, 2013 at 12:54 PM, dbashford notifications@github.comwrote:

Publishing to NPM is a piece of cake. When you create the skeleton (mimosa
mod:init optional -c flag if you want to write it in
coffeescript) it'll drop a package.json in for you. You'll have a few
placeholders to edit inside of it, but other than that it'll just be the
few steps to get yourself added to npm. You can check out any of the
existing modules for packaging examples.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-12712518.

Rob Eisenberg,
Blue Spire Consulting, Inc.
Caliburn Project
850.264.3996

@EisenbergEffect
Copy link
Contributor Author

The biggest barrier for me is that I'm not familiar with node's file system
apis...but I'll figure it out :)

On Fri, Jan 25, 2013 at 12:55 PM, Rob Eisenberg <rob@bluespireconsulting.com

wrote:

Excellent. I'll probably be using the text plugin module as a template,
since it's very close to what I want to do.

On Fri, Jan 25, 2013 at 12:54 PM, dbashford notifications@github.comwrote:

Publishing to NPM is a piece of cake. When you create the skeleton (mimosa
mod:init optional -c flag if you want to write it in
coffeescript) it'll drop a package.json in for you. You'll have a few
placeholders to edit inside of it, but other than that it'll just be the
few steps to get yourself added to npm. You can check out any of the
existing modules for packaging examples.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-12712518.

Rob Eisenberg,
Blue Spire Consulting, Inc.
Caliburn Project
850.264.3996

Rob Eisenberg,
Blue Spire Consulting, Inc.
Caliburn Project
850.264.3996

@EisenbergEffect EisenbergEffect mentioned this pull request Jan 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants