Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/data/import_data.csv missing from release tarball for 1.3.2 #87

Closed
stigtsp opened this issue Mar 30, 2020 · 2 comments
Closed

test/data/import_data.csv missing from release tarball for 1.3.2 #87

stigtsp opened this issue Mar 30, 2020 · 2 comments

Comments

@stigtsp
Copy link

stigtsp commented Mar 30, 2020

Hi,

The release tarball is missing import_data.csv (and liteclirc) causing tests to fail.

$ diff -ur litecli-tag-v1.3.2 litecli-tarball-1.3.2
Only in litecli-tag-v1.3.2: CONTRIBUTING.md
Only in litecli-tag-v1.3.2: .coveragerc
Only in litecli-tag-v1.3.2: .github
Only in litecli-tag-v1.3.2: .gitignore
Only in litecli-tarball-1.3.2: litecli.egg-info
Only in litecli-tarball-1.3.2: PKG-INFO
Only in litecli-tag-v1.3.2: .pre-commit-config.yaml
Only in litecli-tag-v1.3.2: screenshots
diff -ur litecli-tag-v1.3.2/setup.cfg litecli-tarball-1.3.2/setup.cfg
--- litecli-tag-v1.3.2/setup.cfg	2020-03-30 17:51:52.845302447 +0200
+++ litecli-tarball-1.3.2/setup.cfg	2020-03-11 18:55:57.000000000 +0100
@@ -3,16 +3,21 @@
 
 [tool:pytest]
 addopts = --capture=sys
-          --showlocals
-          --doctest-modules
-          --doctest-ignore-import-errors
-          --ignore=setup.py
-          --ignore=litecli/magic.py
-          --ignore=litecli/packages/parseutils.py
-          --ignore=test/features
+	--showlocals
+	--doctest-modules
+	--doctest-ignore-import-errors
+	--ignore=setup.py
+	--ignore=litecli/magic.py
+	--ignore=litecli/packages/parseutils.py
+	--ignore=test/features
 
 [pep8]
 rev = master
 docformatter = True
 diff = True
 error-status = True
+
+[egg_info]
+tag_build = 
+tag_date = 0
+
Only in litecli-tag-v1.3.2/tests: data
Only in litecli-tag-v1.3.2/tests: liteclirc
Only in litecli-tag-v1.3.2: TODO
Only in litecli-tag-v1.3.2: .travis.yml
@amjith
Copy link
Member

amjith commented Mar 30, 2020

I'm surprised tests are included in the release tarball.

I'm curious why you run the tests from the tarball and not from a git clone? I'm trying to understand the use case so I can better serve the need.

@amjith
Copy link
Member

amjith commented Mar 30, 2020

Duh, for making nixOS packages, I presume. I'll include the csv file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants