Fix for bug #12: Config reading is failing when an option is missing.

[j-bennet]

No description provided.

[amjith]

This doesn't fix the issue if someone has removed the smart-completion option from the file.

I also think it can be quite cumbersome in the future to do this check for every option.

I think SafeConfigParser() constructor takes a defaults param where you can specify the defaults for all the options.

That might be a better approach. So see if you can write a helper method that reads the default pgclirc file in the project directory and populate the defaults and then overlay the values from the actual config file .pgclirc.

Feel free to refactor (or remove completely) the helpers in config.py if you think they're too crude or cumbersome.

[j-bennet]

Ah ok.
On 30 Dec 2014 14:57, "Amjith Ramanujam" notifications@github.com wrote:

This doesn't fix the issue if someone has removed the smart-completion
option from the file.

I also think it can be quite cumbersome in the future to do this check for
every option.

I think SafeConfigParser() constructor takes a defaults param where you
can specify the defaults for all the options.

That might be a better approach. So see if you can write a helper method
that reads the default pgclirc file in the project directory and populate
the defaults and then overlay the values from the actual config file
.pgclirc.

Feel free to refactor (or remove completely) the helpers in config.py if
you think they're too crude or cumbersome.

—
Reply to this email directly or view it on GitHub
#13 (comment).