Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manifest to include license in source distribution #38

Merged
merged 1 commit into from
Jun 4, 2017

Conversation

mariusvniekerk
Copy link
Contributor

Description

As part of creating conda-forge packages for pgcli and pgspecial we should include the license in
the source distribution.

Checklist

  • I've added this contribution to the changelog.rst.

@codecov-io
Copy link

codecov-io commented Jun 3, 2017

Codecov Report

Merging #38 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #38   +/-   ##
======================================
  Coverage    51.9%   51.9%           
======================================
  Files           6       6           
  Lines         894     894           
======================================
  Hits          464     464           
  Misses        430     430

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e78bb9...9fdf69a. Read the comment docs.

@amjith
Copy link
Member

amjith commented Jun 4, 2017

Thank you for including the license files. Happy to merge.

Tangential question: I thought conda could install regular python packages without any modifications. Is that not true?

@amjith amjith merged commit cdc491c into dbcli:master Jun 4, 2017
@mariusvniekerk
Copy link
Contributor Author

So it certainly can, however for licenses that require distributing the license files it's preferable to have them as part of the source tarball that is on pypi.

@amjith
Copy link
Member

amjith commented Jun 4, 2017

for licenses that require distributing the license files it's preferable to have them as part of the source tarball that is on pypi.

Yes. You're correct about including the licenses file. I was just wondering about conda because you mentioned that this change was required especially for building a conda-forge package.

@mariusvniekerk
Copy link
Contributor Author

mostly because the conda forge maintainers ask nicely :P

@mariusvniekerk mariusvniekerk deleted the patch-1 branch June 4, 2017 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants