Skip to content
This repository has been archived by the owner on Jan 3, 2021. It is now read-only.

Refresh completions in background #22

Merged
merged 5 commits into from
Oct 30, 2015
Merged

Refresh completions in background #22

merged 5 commits into from
Oct 30, 2015

Conversation

eliangcs
Copy link
Member

No description provided.

@amjith
Copy link
Member

amjith commented Oct 26, 2015

There is one corner case to consider. I had to address this in pgcli: dbcli/pgcli#388

When you run \c db_name to change a database we need to reset the completion data-structures to empty before kicking of the refresh routine. Otherwise, while the refresh is happening in the background, we'll continue to suggest the tables/columns from the previous database.

eliangcs added a commit that referenced this pull request Oct 30, 2015
@eliangcs
Merge pull request #22 from dbcli/eliangcs/background-refresh-complet…
628c0ad 
…ions

Refresh completions in background
@eliangcs eliangcs merged commit 628c0ad into master Oct 30, 2015
@eliangcs eliangcs mentioned this pull request Oct 30, 2015
Closed
@eliangcs eliangcs deleted the eliangcs/background-refresh-completions branch March 17, 2016 06:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eliangcs @amjith