Skip to content

Commit

Permalink
dbeaver/pro#2676 Use fully qualified names checkbox for SQL DDL view …
Browse files Browse the repository at this point in the history
…generation
  • Loading branch information
HocKu7 committed May 22, 2024
1 parent a7eec65 commit 04b843c
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -616,8 +616,12 @@ public static void setArrayParameter(JDBCPreparedStatement dbStat, int index, Li
}
}

public static String getViewDDL(DBRProgressMonitor monitor, PostgreViewBase view, String definition,
Map<String, Object> options) throws DBException {
public static String getViewDDL(

Check warning on line 619 in plugins/org.jkiss.dbeaver.ext.postgresql/src/org/jkiss/dbeaver/ext/postgresql/PostgreUtils.java

View check run for this annotation

Jenkins-CI-integration / CheckStyle Report

plugins/org.jkiss.dbeaver.ext.postgresql/src/org/jkiss/dbeaver/ext/postgresql/PostgreUtils.java#L619

Missing a Javadoc comment.
@NotNull DBRProgressMonitor monitor,
@NotNull PostgreViewBase view,
@NotNull String definition,
@NotNull Map<String, Object> options
) throws DBException {
// In some cases view definition already has view header (e.g. Redshift + with no schema binding)
if (definition.toLowerCase(Locale.ENGLISH).startsWith("create ")) {
return definition;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -130,11 +130,13 @@ public static String getTableDDL(@NotNull DBRProgressMonitor monitor, @NotNull D
return generateTableDDL(monitor, table, options, addComments);
}

public static <T extends DBSEntity> void generateTableListDDL(@NotNull DBRProgressMonitor monitor,
@NotNull StringBuilder sql,
@NotNull Collection<T> tablesOrViews,
Map<String, Object> options,
boolean addComments) throws DBException {
public static <T extends DBSEntity> void generateTableListDDL(

Check warning on line 133 in plugins/org.jkiss.dbeaver.model/src/org/jkiss/dbeaver/model/struct/DBStructUtils.java

View check run for this annotation

Jenkins-CI-integration / CheckStyle Report

plugins/org.jkiss.dbeaver.model/src/org/jkiss/dbeaver/model/struct/DBStructUtils.java#L133

Missing a Javadoc comment.
@NotNull DBRProgressMonitor monitor,
@NotNull StringBuilder sql,
@NotNull Collection<T> tablesOrViews,
Map<String, Object> options,
boolean addComments
) throws DBException {
List<T> goodTableList = new ArrayList<>();
List<T> cycleTableList = new ArrayList<>();
List<T> viewList = new ArrayList<>();
Expand Down

0 comments on commit 04b843c

Please sign in to comment.