#17305 Fix error message on unable to create new default data source …

…config file (#17385) #17305 Create default data sources config file if there is no such #17305 Fix code style #17305 Fix code style #17305 Refactor legacy data sources config path detection #17305 Fix data sources config loading
dbeaver · Aug 18, 2022 · c138b79 · c138b79
1 parent c1b4fb2
commit c138b79
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 4 deletions.
diff --git a/...ss.dbeaver.registry/src/org/jkiss/dbeaver/registry/DataSourceConfigurationManagerNIO.java b/...ss.dbeaver.registry/src/org/jkiss/dbeaver/registry/DataSourceConfigurationManagerNIO.java
@@ -111,7 +111,11 @@ public List<DBPDataSourceConfigurationStorage> getConfigurationStorages() {
     @Override
     public InputStream readConfiguration(@NotNull String name) throws IOException {
         Path path = getConfigurationPath(false).resolve(name);
-        if (!Files.exists(path)) {
+        if (Files.notExists(path)) {
+            // maybe it's .dbeaver-data-sources*.xml in the project folder (DBeaver < 6.1.3 (Legacy))
+            path = project.getAbsolutePath().resolve(name);
+        }
+        if (Files.notExists(path)) {
             return null;
         }
         return Files.newInputStream(path);

diff --git a/plugins/org.jkiss.dbeaver.registry/src/org/jkiss/dbeaver/registry/DataSourceRegistry.java b/plugins/org.jkiss.dbeaver.registry/src/org/jkiss/dbeaver/registry/DataSourceRegistry.java
@@ -46,7 +46,10 @@
 import org.jkiss.utils.ArrayUtils;
 import org.jkiss.utils.CommonUtils;
 
+import java.io.IOException;
 import java.lang.reflect.InvocationTargetException;
+import java.nio.file.Files;
+import java.nio.file.Paths;
 import java.util.*;
 import java.util.function.Predicate;
 import java.util.stream.Collectors;
@@ -170,7 +173,16 @@ DBPDataSourceConfigurationStorage getDefaultStorage() {
                 }
             }
             // No default storage. Seems to be an internal error
-            throw new IllegalStateException("no default storage in registry " + this);
+            log.warn("no default storage in registry " + this);
+            try {
+                java.nio.file.Path configPath = this.getProject().getMetadataFolder(false).resolve(MODERN_CONFIG_FILE_NAME);
+                Files.createFile(configPath);
+                DBPDataSourceConfigurationStorage defaultStorage = new DataSourceFileStorage(configPath, false, true);
+                this.storages.add(defaultStorage);
+                return defaultStorage;
+            } catch (IOException e) {
+                throw new IllegalStateException("Unable to create a default storage in registry " + this, e);
+            }
         }
     }
 

diff --git a/...org.jkiss.dbeaver.registry/src/org/jkiss/dbeaver/registry/DataSourceSerializerModern.java b/...org.jkiss.dbeaver.registry/src/org/jkiss/dbeaver/registry/DataSourceSerializerModern.java
@@ -363,7 +363,9 @@ public void parseDataSources(
                         credJson,
                         new TypeToken<Map<String, Map<String, Map<String, String>>>>() {
                         }.getType());
-                    secureProperties.putAll(res);
+                    if (res != null) {
+                        secureProperties.putAll(res);
+                    }
                 } catch (Exception e) {
                     log.error("Error decrypting secure credentials", e);
                 }
@@ -526,7 +528,7 @@ public void parseDataSources(
                     }
                     dataSource = new DataSourceDescriptor(
                         registry,
-                        registry.getDefaultStorage(),
+                        configurationStorage,
                         origin,
                         id,
                         driver,