Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertica - Please include option to disable comments altogether #16397

Closed
alattke-chwy opened this issue May 3, 2022 · 13 comments · Fixed by #18781
Closed

Vertica - Please include option to disable comments altogether #16397

alattke-chwy opened this issue May 3, 2022 · 13 comments · Fixed by #18781

Comments

@alattke-chwy
Copy link

This is related to issue #14625 .
Reading from comments system table (even though it is not populated in our DB) takes a long time and is I/O intensive.
I am on version 22.0.4.202205011839.
Please provide an option to disable comments altogether as it takes 14s in test env and over a min in a busy prod cluster.

@LonwoLonwo
Copy link
Member

Ok, thanks for the idea.

@alattke-chwy
Copy link
Author

Hi @LonwoLonwo . We are in the process of reviewing DBeaver vs DBVisualizer. Could you let me know if this bug fix is on the roadmap?

@LonwoLonwo
Copy link
Member

We added lazy comments loading in #16396

Now tables loading should be faster in DBeaver.

@LonwoLonwo
Copy link
Member

So for now it is interesting to know - what type of comments prepare you disable now?

@alattke-chwy
Copy link
Author

Thanks for replying. I updated to Version 22.1.0.202206051253. I no longer see this in the Navigation panel, but the Object Properties tab/panel it still happens.

When an object (ex. Table) is opened, this query that is being executed is:

request | select object_type, "comment", child_object from v_catalog.comments where object_schema ='${OBJECT_SCHEMA}' and object_name ='${OBJECT_NAME}'
min_duration_ms     | 11660
max_duration_ms     | 12533
sum_duration_ms     | 24193
count   | 2

So, 2 identical queries, each taking ~12s are running consecutively when building object and tapping into comments system table. (Also, 12s is in an idle system, on a busy system like our prod cluster this takes more than 30s).
If there's an option to disable this in the settings, I am not seeing it.

Thank you!

@LonwoLonwo
Copy link
Member

There is no option for now. But it is in our plans.

@alattke-chwy
Copy link
Author

Thank you!

@emironovDB emironovDB modified the milestones: 22.1.5, 22.3.1 Aug 2, 2022
@alattke-chwy
Copy link
Author

Hi! Can anyone provide an update on this please?

@LonwoLonwo
Copy link
Member

Hello @alattke-chwy

You can see more data about this ticket in the "Milestone" section.

@tati-kru tati-kru modified the milestones: 22.3.1, 22.3.3 Dec 2, 2022
@alattke-chwy
Copy link
Author

Hi. Can someone provide an update to this ticket please?

@alattke-chwy
Copy link
Author

@LonwoLonwo could you please provide an update on this?

@LonwoLonwo
Copy link
Member

2023-01-07 11_06_56-Vertica - Please include option to disable comments altogether · Issue #16397 ·

@LonwoLonwo LonwoLonwo self-assigned this Jan 9, 2023
@tati-kru tati-kru added the sp:2 label Jan 9, 2023
LonwoLonwo added a commit that referenced this issue Jan 16, 2023
@LonwoLonwo LonwoLonwo linked a pull request Jan 16, 2023 that will close this issue
16 tasks
LonwoLonwo added a commit that referenced this issue Jan 16, 2023
LonwoLonwo added a commit that referenced this issue Jan 18, 2023
@Matvey16 Matvey16 self-assigned this Jan 18, 2023
serge-rider added a commit that referenced this issue Jan 18, 2023
* #16397 ability to disable metadata objects comment reading for performance increasing added

* #16397 change setting description

* #16397 move connection setting to the separate connection page; remove constraints comments reading

Co-authored-by: Serge Rider <serge@jkiss.org>
ShadelessFox pushed a commit that referenced this issue Jan 19, 2023
* #16397 ability to disable metadata objects comment reading for performance increasing added

* #16397 change setting description

* #16397 move connection setting to the separate connection page; remove constraints comments reading

Co-authored-by: Serge Rider <serge@jkiss.org>
@LonwoLonwo
Copy link
Member

Implemented.

2023-01-18 14_29_02-DBeaver 22 3 2 - master Script-29

Available in the last DBeaver release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment