Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#13960 timezone selection for Java #16467

Merged
merged 11 commits into from
May 25, 2022
Merged

#13960 timezone selection for Java #16467

merged 11 commits into from
May 25, 2022

Conversation

Destrolaric
Copy link
Member

@Destrolaric Destrolaric commented May 12, 2022 •
edited

image
Now java timezone can be select from preference page.
closes #13960

ShadelessFox
ShadelessFox requested changes May 15, 2022
View reviewed changes
plugins/org.jkiss.dbeaver.core/src/org/jkiss/dbeaver/registry/TimezoneRegistry.java Outdated Show resolved Hide resolved
plugins/org.jkiss.dbeaver.core/src/org/jkiss/dbeaver/registry/TimezoneRegistry.java Outdated Show resolved Hide resolved
plugins/org.jkiss.dbeaver.core/src/org/jkiss/dbeaver/registry/TimezoneRegistry.java Outdated Show resolved Hide resolved
plugins/org.jkiss.dbeaver.core/src/org/jkiss/dbeaver/registry/TimezoneRegistry.java Outdated Show resolved Hide resolved
plugins/org.jkiss.dbeaver.core/src/org/jkiss/dbeaver/registry/TimezoneRegistry.java Outdated Show resolved Hide resolved
...g.jkiss.dbeaver.core/src/org/jkiss/dbeaver/ui/preferences/PrefPageDatabaseUserInterface.java Outdated Show resolved Hide resolved
...g.jkiss.dbeaver.core/src/org/jkiss/dbeaver/ui/preferences/PrefPageDatabaseUserInterface.java Outdated Show resolved Hide resolved
...g.jkiss.dbeaver.core/src/org/jkiss/dbeaver/ui/preferences/PrefPageDatabaseUserInterface.java Outdated Show resolved Hide resolved
...ss.dbeaver.ui.app.standalone/src/org/jkiss/dbeaver/ui/app/standalone/DBeaverApplication.java Outdated Show resolved Hide resolved
plugins/org.jkiss.dbeaver.core/src/org/jkiss/dbeaver/core/CoreResources.properties Outdated Show resolved Hide resolved
ShadelessFox
ShadelessFox requested changes May 16, 2022
View reviewed changes
plugins/org.jkiss.dbeaver.core/src/org/jkiss/dbeaver/registry/TimezoneRegistry.java Outdated Show resolved Hide resolved
...g.jkiss.dbeaver.core/src/org/jkiss/dbeaver/ui/preferences/PrefPageDatabaseUserInterface.java Outdated Show resolved Hide resolved
...g.jkiss.dbeaver.core/src/org/jkiss/dbeaver/ui/preferences/PrefPageDatabaseUserInterface.java Outdated Show resolved Hide resolved
plugins/org.jkiss.dbeaver.core/src/org/jkiss/dbeaver/utils/TimezoneUtils.java Outdated Show resolved Hide resolved
plugins/org.jkiss.dbeaver.core/src/org/jkiss/dbeaver/utils/TimezoneUtils.java Outdated Show resolved Hide resolved
plugins/org.jkiss.dbeaver.core/src/org/jkiss/dbeaver/utils/TimezoneUtils.java Outdated Show resolved Hide resolved
...ss.dbeaver.ui.app.standalone/src/org/jkiss/dbeaver/ui/app/standalone/DBeaverApplication.java Show resolved Hide resolved
@Destrolaric
Copy link
Member Author

java_KSauLL3DIx.mp4

ShadelessFox
ShadelessFox requested changes May 17, 2022
View reviewed changes
plugins/org.jkiss.dbeaver.core/src/org/jkiss/dbeaver/registry/TimezoneRegistry.java Outdated Show resolved Hide resolved
plugins/org.jkiss.dbeaver.core/src/org/jkiss/dbeaver/registry/TimezoneRegistry.java Outdated Show resolved Hide resolved
plugins/org.jkiss.dbeaver.core/src/org/jkiss/dbeaver/registry/TimezoneRegistry.java Outdated Show resolved Hide resolved
plugins/org.jkiss.dbeaver.core/src/org/jkiss/dbeaver/registry/TimezoneRegistry.java Outdated Show resolved Hide resolved
...g.jkiss.dbeaver.core/src/org/jkiss/dbeaver/ui/preferences/PrefPageDatabaseUserInterface.java Show resolved Hide resolved
...g.jkiss.dbeaver.core/src/org/jkiss/dbeaver/ui/preferences/PrefPageDatabaseUserInterface.java Outdated Show resolved Hide resolved
plugins/org.jkiss.dbeaver.core/src/org/jkiss/dbeaver/registry/TimezoneRegistry.java Outdated Show resolved Hide resolved
@Destrolaric Destrolaric force-pushed the timezone_selection#13960 branch 3 times, most recently from 2537bdb to 8c6bbf2 Compare May 17, 2022 10:28
@uslss
Copy link
Member

uslss commented May 18, 2022

Timezone isn't refreshed
image

ShadelessFox
ShadelessFox requested changes May 19, 2022
View reviewed changes
...g.jkiss.dbeaver.core/src/org/jkiss/dbeaver/ui/preferences/PrefPageDatabaseUserInterface.java Show resolved Hide resolved
...g.jkiss.dbeaver.core/src/org/jkiss/dbeaver/ui/preferences/PrefPageDatabaseUserInterface.java Outdated
Comment on lines 227 to 231
if (!clientTimezone.getText().equals(TimezoneRegistry.DEFAULT_VALUE)) {
TimezoneRegistry.setDefaultZone(ZoneId.of(TimezoneRegistry.extractTimezoneId(clientTimezone.getText())));
} else {
TimezoneRegistry.setDefaultZone(null);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to inverse both condition and branches

plugins/org.jkiss.dbeaver.registry/src/org/jkiss/dbeaver/registry/TimezoneRegistry.java Show resolved Hide resolved
plugins/org.jkiss.dbeaver.registry/src/org/jkiss/dbeaver/registry/TimezoneRegistry.java Show resolved Hide resolved
plugins/org.jkiss.dbeaver.registry/src/org/jkiss/dbeaver/registry/TimezoneRegistry.java Show resolved Hide resolved
plugins/org.jkiss.dbeaver.registry/src/org/jkiss/dbeaver/registry/TimezoneRegistry.java Show resolved Hide resolved
@uslss
Copy link
Member

uslss commented May 24, 2022

tz is incorrectly updated.
Start application with UTC+2 (CET) - ok
Switch to UTC+3 (MSK) and apply changes - CET is still shown
Switch back to UTC+2 and apply - MSK is shown
Switch to GMT and apply - CET is shown
dbeaver_WVAhqIq6Lv

@uslss
Copy link
Member

uslss commented May 24, 2022

verified

@serge-rider serge-rider merged commit 85737af into devel May 25, 2022
@Destrolaric Destrolaric deleted the timezone_selection#13960 branch June 28, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShadelessFox ShadelessFox ShadelessFox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chose the timezone in dbeaver option
4 participants
@Destrolaric @uslss @ShadelessFox @serge-rider