Insert Color in Query plan's treeView #33040
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : #23407
PR : #26459
We proceeded by referring to the above issues and PR.
![image](https://private-user-images.githubusercontent.com/68524199/331032672-73a0767a-ed67-46c2-83e5-9f62654fad7a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg3Mjg5NjUsIm5iZiI6MTcxODcyODY2NSwicGF0aCI6Ii82ODUyNDE5OS8zMzEwMzI2NzItNzNhMDc2N2EtZWQ2Ny00NmMyLTgzZTUtOWY2MjY1NGZhZDdhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjE4VDE2Mzc0NVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTg1ZTg5ZTg5NmI2NzY3NDMyYzUzNjc5ZjJiYmE1M2RhMzgxYWZiYWQ3NTFlNDg5OTM4N2JkNWFmMTM5ODJlY2YmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.iD-nRs_IEVcSO1Z3dyASbSLYEJxs-Lf49cBo96oHcb0)
![image](https://private-user-images.githubusercontent.com/68524199/331032696-2c04aae7-53d0-4cf7-8eb2-fce2dbaa2f94.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg3Mjg5NjUsIm5iZiI6MTcxODcyODY2NSwicGF0aCI6Ii82ODUyNDE5OS8zMzEwMzI2OTYtMmMwNGFhZTctNTNkMC00Y2Y3LThlYjItZmNlMmRiYWEyZjk0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjE4VDE2Mzc0NVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRiMDQzOTJhNzliN2E5ZmZmOGFkODRjYmRjNTdhYjE4ZGIzMjk2Zjk4OGUzZDk2OWUzOTA2YWIyNmYxYjhjODAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.bp9s9LQ6o241ZVusDXzpN79pHNbcPEGxzVRhmnOV38o)
And I wanted to display oracle as well, but the kind information seems to be different.
(I don't know if it's different for each version, but 'foregin' is not displayed until versions 9 to 11.)
I think need to add "table access" to allowedkind in OraclePlanNode
and distinguish between 'FULL SCAN' and 'NOT_FULL_TABLESCAN'.
If do this, it will display normally as shown below.
![image](https://private-user-images.githubusercontent.com/68524199/331032770-d1c4db33-32bd-45f9-b830-de9225ab0b8d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg3Mjg5NjUsIm5iZiI6MTcxODcyODY2NSwicGF0aCI6Ii82ODUyNDE5OS8zMzEwMzI3NzAtZDFjNGRiMzMtMzJiZC00NWY5LWI4MzAtZGU5MjI1YWIwYjhkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjE4VDE2Mzc0NVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZiNDhlZDc5NDNlMGQ0NWI2NzRlZTM5MmU0OWFlOGNiNmIwYjgzMWVhMzM3YmUyNmQxZGRjMTU4NzBlNmUzOGMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.pyPBn-3Godf77YP6lDyVnrIxLbO1N7gZOUog8g46lHo)
![image](https://private-user-images.githubusercontent.com/68524199/331032792-b5013a48-cbe7-41c9-be36-1582cf2ba09b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg3Mjg5NjUsIm5iZiI6MTcxODcyODY2NSwicGF0aCI6Ii82ODUyNDE5OS8zMzEwMzI3OTItYjUwMTNhNDgtY2JlNy00MWM5LWJlMzYtMTU4MmNmMmJhMDliLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjE4VDE2Mzc0NVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTA5Yjg0N2RlZjVlMjFmNDkyMGQxMGJhMzkzMTIyNTdkZjJjMWFjNTdmOTgzOWNhMzNmOTY2MzNjNGQ4MjRhMTQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.pTDhuJrUDt_9CWvSrwfEv0cPktb8PGnqPJqnCxB5a7k)
If possible, I'd like to include this in the PR as well.