dbeaver/dbeaver#26613 Fix json format for binary column exporting #34059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E1izabeth
approved these changes
May 23, 2024
| @@ -53,6 +53,8 @@ public interface IStreamDataExporterSite { | |||
|
|
|||
| void writeBinaryData(@NotNull DBDContentStorage cs) throws IOException; | |||
|
|
|||
| void writeBinaryData(@NotNull DBDContentStorage cs, String typeOfOutput) throws IOException; | |||
| writer.write(binaryString); | ||
| break; | ||
| } | ||
| } | ||
| default: { | ||
| // Binary stream | ||
| try (Reader reader = new InputStreamReader(stream, cs.getCharset())) { | ||
| String string = IOUtils.readToString(reader); |
There was a problem hiding this comment.
This is a big no. It might be a really big blob (like several GBs in size) that we would otherwise just pipe to the output stream (writer).
HocKu7
force-pushed
the
dbeaver/dbeaver#26613-binary-column-json-exporting
branch
3 times, most recently
from
c2499e1
to
3327999
Compare
HocKu7
force-pushed
the
dbeaver/dbeaver#26613-binary-column-json-exporting
branch
from
3327999
to
af53c81
Compare
HocKu7
force-pushed
the
dbeaver/dbeaver#26613-binary-column-json-exporting
branch
from
e1f0f22
to
ed89583
Compare
|
verified |
serge-rider
deleted the
dbeaver/dbeaver#26613-binary-column-json-exporting
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.