Fix support for BIGINT in SPL params #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just noticed I need to rebase this onto the updated |
MMatten
force-pushed
the
support-bigint-in-teradata-stored-proc-params
branch
from
524537f
to
2ee0720
Compare
|
Rebase done. |
| @@ -1,6 +1,6 @@ | |||
| This stored proc tests output parameters - CalcLength returns string length as second output param | |||
|
|
|||
| |Execute Ddl|!-Replace Procedure CalcLength(in name varchar(100), out strlength numeric) | |||
| |Execute Ddl|!-Replace Procedure CalcLength(in name varchar(100), out strlength bigint) | |||
There was a problem hiding this comment.
As we're removing the numeric version here - do we have some other test which is still covering the numeric behavior?
There was a problem hiding this comment.
We're still covered in StoredProcWithException.
None of the data type tests for Teradata stored price and functions are explicit enough really. I wonder if we could define some standard tests sections and use !includes to supply the specific content for each DB sometime.
There was a problem hiding this comment.
OK. Seems good enough to me for now.
|
:+1 I'm merging this. Thank you @MMatten for the quick fix! |
javornikolov
added a commit
that referenced
this pull request
Jul 8, 2015
…proc-params Fix support for BIGINT in SPL params
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected type mappings to fix #387.