-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support long Teradata object names #402
Conversation
Long tables/column names are supported in Teradata from version 14.10. Teradata Express is only available up to version 14 at the moment so we'll need assistance to test names between 31 and 128 characters. |
Thanks @MMatten . |
Thanks. I'll need to ask the raiser of #400 to download this and test with Teradata 14.10+. |
The new |
What about DB2, Derby, HSQLDB, MS SQL Server? |
Aha! I've forgotten to commit the symlink updates in the |
e2223e7
to
ed78169
Compare
Missing symlinks added for adaptors not using all of Note that adapters that have a 128 char name length limit use the names from the |
':dbfit-java:teradata:check', | ||
':dbfit-java:derby:integrationTest', | ||
':dbfit-java:hsqldb:integrationTest' | ||
':dbfit-java:core:check' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would vote for keeping the commas at the end of line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for the fastbuild
.
The pain is on the integrationBuild
- when I uncomment ':dbfit-java:teradata:integrationTest'
I have to remember to remove the comma from the end of ':dbfit-java:sqlserver:integrationTest'
- always forget!
Ok to have different formatting/style?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leading comma is a bit unnatural for people to read. Besides - I think we rarely commit changes to this list. If its some personal customization - it's perhaps better to keep customizations in separate (optional) non-version controlled file which to load if present (since it will be personal, anyone can use own style and formatting).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I don't mind that.
Any ideas on how to extend the build customisation using another (non version controlled) file (or something like environment variables)?
I've reverted the comma position in I've not bothered making this iterate over a list of DB type names/integration test tasks but just to show the basic idea. What do you think? |
Let's extract to a separate PR the configuration of excluded/included integration tests. (Seems a bit off-topic in the context of Teradata long names support). The rest looks OK to me. |
586ff10
to
4233a58
Compare
Good idea. It's getting too in depth for this PR. Now removed from this one. |
Support long Teradata object names
CoreTests
test to test long names for all supported DB types.resolves #400