MySql: support for unreferenced BIT columns

[javornikolov]

This is to be able to support e.g. updating table which contains BIT column via dbfit Update fixture when the bit column itself is not referenced.

Also it's possibly covering (but not yet tested) referring single BIT columns BIT (1). For longer BIT data types BIT(n > 1) referring such columns is not supported.

As per the MySql driver documentation: the Java type is different for BIT(1) and BIT(n > 1).

TODO:

• Add acceptance tests
• Test if the original problem is being solved

---

The problem has been originally reported on the mailing list. Update like following.

|Update |mytable |
|field1= |field2 |
|value1 |value2 |

results in exception:

java.lang.UnsupportedOperationException: Type BIT is not supported
 at dbfit.environment.MySqlEnvironment.getSqlType(MySqlEnvironment.java:143)
 at dbfit.environment.MySqlEnvironment.readColumnsFromDb(MySqlEnvironment.java:79)
 at dbfit.environment.MySqlEnvironment.getAllColumns(MySqlEnvironment.java:61)
 at dbfit.fixture.Update.initParameters(Update.java:101)
 at dbfit.fixture.Update.doRows(Update.java:86)
 at fit.Fixture.doTable(Fixture.java:156)
 at fitlibrary.traverse.AlienTraverseHandler.doTable(AlienTraverseHandler.java:21)
 at fitlibrary.traverse.workflow.DoTraverseInterpreter.interpretWholeTable(DoTraverseInterpreter.java:104)
 at fitlibrary.traverse.workflow.DoTraverseInterpreter.interpretWholeTable(DoTraverseInterpreter.java:89)
 at fitlibrary.DoFixture.interpretWholeTable(DoFixture.java:73)
 at fitlibrary.suite.InFlowPageRunner.run(InFlowPageRunner.java:27)
 at fitlibrary.DoFixture.interpretTables(DoFixture.java:42)
 at dbfit.DatabaseTest.interpretTables(DatabaseTest.java:26)
 at fit.Fixture.doTables(Fixture.java:81)
 at fit.FitServer.process(FitServer.java:81)
 at fit.FitServer.run(FitServer.java:56)
 at fit.FitServer.main(FitServer.java:41)

The columns in the UPDATE are varchar but there is a bit field in the table.

[MMatten]

How much more work is it to support BIT(1) in Insert/Update/Clean/Query fixtures?

[javornikolov]

How much more work is it to support BIT(1) in Insert/Update/Clean/Query fixtures?

My assumption is that it's already working: but I haven't tested anything yet. If we refer a BIT(1) column - then a question emerges how are the values represented: right now it's mapped to Boolean which would allow true, false as far as I remember. (While one might find 0, 1 notation more appropriate).

[MMatten]

And, do we really want to have to handle BIT(n>1) differently? May be it!s time to introduce the general binary handler.

[javornikolov]

BIT(n) seems to be mapped to byte[] while BIT(1) is Boolean. But indeed - on FitNesse test level it perhaps makes sense to use one the same notation (otherwise it would be confusing for users).

I would vote for splitting this into two:

• We don't claim any support for referring BIT columns; just allow having them in the table. (This was my initial intention with this PR). This is in order to resolve the issue reported on the mailing list.
• Later we can add support for using BIT columns (1 or more bits).

[MMatten]

Sounds good to me too.

A general binary (hex) handler would be really useful and allow us to move on a few of the existing issues too. I think that would be my vote for our next new feature.

[MMatten]

On a side note, I think Travis supports some DB types (MySQL and perhaps Postgres) so perhaps we could extend the fastbuild or create another build task for the CI.