Oracle jdbc 12 support #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Any idea why it was built like that? |
Type mappings used to be by exact class name - at that point it wouldn't work to map an interface when concrete class is expected. At some point we extended the lookup to check for mappings of parents too - which allows the patch I did now (perhaps with some performance overhead on the 1st lookup, hopefully negligible). |
Drop reference of internal oracle class oracle.jdbc.driver.OracleResultSetImpl which is not present in latest jdbc version any more. Use standard java.sql.ResultSet instead.
javornikolov
force-pushed
the
topic/ojdbc-12-support
branch
from
a0999b7
to
00ba2ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop reference to an internal oracle class oracle.jdbc.driver.OracleResultSetImpl which is not present in latest jdbc version any more. Use standard java.sql.ResultSet instead.
resolves #164