Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance HSQLDB stored routine support #554

Merged
merged 4 commits into from
Mar 11, 2017

Conversation

MMatten
Copy link
Contributor

@MMatten MMatten commented Mar 11, 2017

Supersedes #553, #541 and #535.

@javornikolov
Copy link
Contributor

@MMatten, that looks good to me 👍. Unless you have more changes to add - I think we can merge it?

@MMatten
Copy link
Contributor Author

MMatten commented Mar 11, 2017

@javornikolov I've nothing else to add.

@MMatten
Copy link
Contributor Author

MMatten commented Mar 11, 2017

I'll close down the other PRs.

@javornikolov
Copy link
Contributor

@javornikolov I've nothing else to add.

Cool! I'm merging it then ... Thanks a lot @MMatten !

I'll close down the other PRs.

In general this can be also done by closes #nnn comment in the PR (https://help.github.com/articles/closing-issues-via-commit-messages/). Anyway - not a big deal to do it manually :-)

@javornikolov javornikolov added this to the Next milestone Mar 11, 2017
@javornikolov javornikolov merged commit 388dbb6 into master Mar 11, 2017
@javornikolov javornikolov deleted the enhance-hsqldb-stored-routine-support branch March 11, 2017 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants