Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol setter value parser support #562

Merged
merged 1 commit into from
Mar 19, 2017

Conversation

javornikolov
Copy link
Contributor

@javornikolov javornikolov commented Mar 18, 2017

Add support for specifying value parser class in SetParameter fixture. This allows setting non-String parameters. Partially addresses #557.

TODO:

  • Update the documentation - describe the new feature and remove notes that "only string" can be set.
  • Consider slicing the ValueParser refactoring to separate PR

@javornikolov javornikolov added this to the Next milestone Mar 18, 2017
@javornikolov javornikolov force-pushed the topic/symbol-setter-value-parser branch from 04a719f to 6a187b0 Compare March 19, 2017 13:42
Add an optional 3rd parameter of SetParameter fixture pointing to a
parse delegate which to parse the given text to Object. Classes with
static parse(String) or valueOf(String) methods are supported as parse
delegates. If both valueOf and parse methods are present, valueOf is
with higher priority.
@javornikolov javornikolov force-pushed the topic/symbol-setter-value-parser branch from 6a187b0 to 79c65d1 Compare March 19, 2017 14:22
@javornikolov javornikolov merged commit f7ba03c into master Mar 19, 2017
@javornikolov javornikolov deleted the topic/symbol-setter-value-parser branch March 19, 2017 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant