Informix CalcLength: rename 1st arg to unify the definition

[javornikolov]

Rename CalcLength 1st argument to Name in order to have the same definition across all databases. This fixes common Symbols test relying on CalcLength.

[MMatten]

I'll test this shortly.

There is a small typo in the commit message (CalcLenght).

[javornikolov]

There is a small typo in the commit message (CalcLenght).

Fixed and force-pushed.

[MMatten]

Tests failing now at:

CoreTests.CommonSuite.Symbols

[javornikolov]

@MMatten, what exactly is faiilng?

Have you recreated the Informix stored procs? I renamed one of the arguments of CalcLength stored procedure - so it needs to be updated in the database.

[MMatten]

@MMatten, what exactly is
Have you recreated the Informix stored procs? I renamed one of the arguments of CalcLength stored procedure - so it needs to be updated in the database.

I rebuilt the VM from this branch so it will have the updated stored proc. I'll pull out the error message and stack trace tomorrow.

[MMatten]

Hmmm. Perhaps I'm losing my mind. The failure was in: -

DbFit.AcceptanceTests.JavaTests.PostgresTests.FlowMode.CoreTests.CommonSuite.Symbols

Error message:

java.sql.SQLException: Cannot find parameter "strlength"
	at dbfit.api.DbStoredProcedure.findAccessorForParamWithName(DbStoredProcedure.java:42)
	at dbfit.api.DbStoredProcedure.getDbParameterAccessor(DbStoredProcedure.java:29)
	at dbfit.fixture.DbObjectExecutionFixture.getAccessors(DbObjectExecutionFixture.java:121)
	at dbfit.fixture.DbObjectExecutionFixture.getAccessors(DbObjectExecutionFixture.java:108)
	at dbfit.fixture.DbObjectExecutionFixture.doRows(DbObjectExecutionFixture.java:71)
	at fit.Fixture.doTable(Fixture.java:156)
	at fitlibrary.traverse.AlienTraverseHandler.doTable(AlienTraverseHandler.java:21)
	at fitlibrary.traverse.workflow.DoTraverseInterpreter.interpretWholeTable(DoTraverseInterpreter.java:104)
	at fitlibrary.traverse.workflow.DoTraverseInterpreter.interpretWholeTable(DoTraverseInterpreter.java:89)
	at fitlibrary.DoFixture.interpretWholeTable(DoFixture.java:73)
	at fitlibrary.suite.InFlowPageRunner.run(InFlowPageRunner.java:27)
	at fitlibrary.DoFixture.interpretTables(DoFixture.java:42)
	at dbfit.DatabaseTest.interpretTables(DatabaseTest.java:26)
	at fit.Fixture.doTables(Fixture.java:81)
	at fit.FitServer.process(FitServer.java:81)
	at fit.FitServer.run(FitServer.java:56)
	at fit.FitServer.main(FitServer.java:41)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at fitnesse.testsystems.fit.CommandRunningFitClient$InProcessCommandRunner.tryCreateTestRunner(CommandRunningFitClient.java:262)
	at fitnesse.testsystems.fit.CommandRunningFitClient$InProcessCommandRunner.access$100(CommandRunningFitClient.java:213)
	at fitnesse.testsystems.fit.CommandRunningFitClient$InProcessCommandRunner$1.run(CommandRunningFitClient.java:252)
	at java.lang.Thread.run(Thread.java:748)

[javornikolov]

Hmmm. Perhaps I'm losing my mind. The failure was in: -

DbFit.AcceptanceTests.JavaTests.PostgresTests.FlowMode.CoreTests.CommonSuite.Symbols

@MMatten, this PR is created out of master where we don't have the Postgres fix yet. We're fixing the Informix only here (it appears to be a separate independent issue).

[javornikolov]

So for this PR we only need to run the Informix integration test.

[MMatten]

They pass 👍

[javornikolov]

Nice :-) Thanks for the feedback @MMatten! I'm merging that and I'll rebase the branch behind the other PR to pick this change here.