Allow parameter name patterns to be varied from and restored to default values. #622

MMatten · 2018-02-06T20:04:22Z

Allow parameter name pattern to be varied from and restored to the default name pattern string for each adapter via a new Parameter Pattern option.

MMatten · 2018-02-06T20:06:03Z

dbfit-java/netezza/src/main/java/dbfit/environment/NetezzaEnvironment.java


    public Pattern getParameterPattern() {
-        return paramsNames;
+    	return Pattern.compile(getParamPattern());


Whitespace issue here noted.

javornikolov · 2018-02-06T20:45:16Z

@MMatten I think something that should be OK.

Just we rather have diffent naming since it's hard to guess what's the difference between getParameterPattern and getParamPattern.

MMatten · 2018-02-06T20:46:11Z

Just we rather have diffent naming since it's hard to guess what's the difference between getParameterPattern and getParamPattern.

Very true. I was already thinking of that too.

How about public Pattern getParameterPattern() and private getParamPatternString()?

javornikolov · 2018-02-07T19:03:47Z

It's still a bit confusing. The distinguishing part I think is that one of these is the default pattern (for the environment), isn't it?

Edit: above comment was a bit down the road and before I look at the current implementation. For the current implementation it might be OK except maybe that we have Param abbreviated in one of these (what about using the full name).

Another question is do we need any of these to be public? (Hmm, I see it used to be public so far).

javornikolov · 2018-02-07T19:17:24Z

In general seems good to me. I guess we can merge it after polishing the naming.

MMatten · 2018-02-07T22:07:37Z

@javornikolov I still have to test this over some of the adapters but any review comments at this stage would be great.

MMatten · 2018-02-08T18:14:20Z

I'm not sure how my local build didn't pick up that unused import. Fixed and force pushed.

javornikolov · 2018-02-08T18:49:12Z

dbfit-java/core/src/main/java/dbfit/api/AbstractDbEnvironment.java

-    protected abstract Pattern getParameterPattern();
+    protected String defaultParamPatternString = "";
+
+    protected String getParamPatternString() {


Can we keep that method private (if we want a separate method at all)?

Ah, I see we're using it in subclasses. I'm wondering about the getParameterPattern().toString() alternative. My point is that having too many methods which is possible to override might lead to some confusion when implementing a new adapter.

javornikolov · 2018-02-08T18:50:18Z

dbfit-java/core/src/main/java/dbfit/api/AbstractDbEnvironment.java

+            defaultParamPatternString : Options.get(Options.OPTION_PARAMETER_PATTERN);
+    }
+
+    //protected abstract Pattern getParameterPattern();


Isn't that comment redundant? Maybe we rather refer to defaultParamPatternString attribute as a comment here?

MMatten · 2018-02-08T22:11:41Z

dbfit-java/db2/src/main/java/dbfit/environment/DB2iEnvironment.java

@@ -23,20 +22,15 @@

    public DB2iEnvironment(String driverClassName) {
        super(driverClassName);
+        defaultParamPatternString = "[@:]([A-Za-z0-9_]+)";
+


I'll delete this extra blank line.

MMatten · 2018-02-08T22:12:55Z

dbfit-java/hsqldb/src/main/java/dbfit/environment/HSQLDBEnvironment.java

-        return paramRegex;
+    protected String parseCommandText(String commandText) {
+        commandText = commandText.replaceAll(getParamPatternString(), "?");
+        return super.parseCommandText(commandText);


@javornikolov I'm thinking that now I've got this block in every adapter I should merge it into the super-class's method.

MMatten · 2018-02-10T14:58:30Z

@javornikolov I've now tested the current PR state with all adapters.

MMatten · 2018-02-12T19:12:39Z

@javornikolov I think I've tidied things up a little. What do you think about the current methods and visibility of them in AbstractDbEnvironment?

MMatten · 2018-02-21T20:44:49Z

@javornikolov do you think this is close to being mergeable yet?

javornikolov · 2018-02-21T21:25:40Z

@MMatten, sorry for the delay! Thank you for the reminder :-)
It looks OK to me though I have some wondering about about protected attributes vs methods: but it's theoretica for now. I'm merging this PR.

Arun-Karunakaran · 2018-03-14T10:26:38Z

Hi Team,

I am trying to explore how can i connect to command line terminal and execute unix/shell commands.
Please help suggest me with a sample example on how to do it. I am exploring on this for past several days. I tried even with downloading the latest jar file commandlinefixture.jar but it is throwing error while i am using it in dbfit syntax. Can you elaborate on the steps to perform it.
Thanks & regards,
Arun K

MMatten · 2018-03-15T10:08:30Z

Use the full class name including the package name part or try |Import| of the package name.

…

Sent from my iPhone On 14 Mar 2018, at 10:26, nohoyuar <notifications@github.com<mailto:notifications@github.com>> wrote: Hi Team, I am trying to explore how can i connect to command line terminal and execute unix/shell commands. Please help suggest me with a sample example on how to do it. I am exploring on this for past several days. I tried even with downloading the latest jar file commandlinefixture.jar but it is throwing error while i am using it in dbfit syntax. Can you elaborate on the steps to perform it. Thanks & regards, Arun K — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#622 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABztFQ1eVqyU1kGSVeuMrY3csDnhhMAOks5tePBfgaJpZM4R7pkJ>.

MMatten commented Feb 6, 2018

View reviewed changes

MMatten force-pushed the allow-variable-param-name-patterns branch from daadd68 to 3652629 Compare February 6, 2018 20:31

MMatten force-pushed the allow-variable-param-name-patterns branch from 3652629 to e8fb688 Compare February 7, 2018 22:04

MMatten changed the title ~~Draft for variable param names~~ Allow parameter name patterns to be varied from and restored to default values. Feb 7, 2018

MMatten force-pushed the allow-variable-param-name-patterns branch from e8fb688 to ba98a1b Compare February 8, 2018 18:13

javornikolov reviewed Feb 8, 2018

View reviewed changes

MMatten commented Feb 8, 2018

View reviewed changes

MMatten force-pushed the allow-variable-param-name-patterns branch 2 times, most recently from 1896078 to 13d973a Compare February 9, 2018 21:46

Allow parameter name patterns to be varied/defaulted via new option

a786411

MMatten force-pushed the allow-variable-param-name-patterns branch from 13d973a to a786411 Compare February 12, 2018 18:56

javornikolov added this to the 4.0.0 milestone Feb 21, 2018

javornikolov added the enhancement label Feb 21, 2018

javornikolov merged commit 59114d0 into master Feb 21, 2018

javornikolov deleted the allow-variable-param-name-patterns branch February 21, 2018 21:26

MMatten mentioned this pull request Feb 24, 2018

Request to change Netezza parameter / bind variable name pattern #621

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow parameter name patterns to be varied from and restored to default values. #622

Allow parameter name patterns to be varied from and restored to default values. #622

MMatten commented Feb 6, 2018 •

edited

MMatten Feb 6, 2018

javornikolov commented Feb 6, 2018

MMatten commented Feb 6, 2018 •

edited

javornikolov commented Feb 7, 2018 •

edited

javornikolov commented Feb 7, 2018

MMatten commented Feb 7, 2018

MMatten commented Feb 8, 2018

javornikolov Feb 8, 2018

javornikolov Feb 8, 2018

javornikolov Feb 8, 2018

MMatten Feb 8, 2018

MMatten Feb 8, 2018

MMatten commented Feb 10, 2018

MMatten commented Feb 12, 2018

MMatten commented Feb 21, 2018

javornikolov commented Feb 21, 2018

Arun-Karunakaran commented Mar 14, 2018

MMatten commented Mar 15, 2018 via email

Allow parameter name patterns to be varied from and restored to default values. #622

Allow parameter name patterns to be varied from and restored to default values. #622

Conversation

MMatten commented Feb 6, 2018 • edited

MMatten Feb 6, 2018

Choose a reason for hiding this comment

javornikolov commented Feb 6, 2018

MMatten commented Feb 6, 2018 • edited

javornikolov commented Feb 7, 2018 • edited

javornikolov commented Feb 7, 2018

MMatten commented Feb 7, 2018

MMatten commented Feb 8, 2018

javornikolov Feb 8, 2018

Choose a reason for hiding this comment

javornikolov Feb 8, 2018

Choose a reason for hiding this comment

javornikolov Feb 8, 2018

Choose a reason for hiding this comment

MMatten Feb 8, 2018

Choose a reason for hiding this comment

MMatten Feb 8, 2018

Choose a reason for hiding this comment

MMatten commented Feb 10, 2018

MMatten commented Feb 12, 2018

MMatten commented Feb 21, 2018

javornikolov commented Feb 21, 2018

Arun-Karunakaran commented Mar 14, 2018

MMatten commented Mar 15, 2018 via email

MMatten commented Feb 6, 2018 •

edited

MMatten commented Feb 6, 2018 •

edited

javornikolov commented Feb 7, 2018 •

edited