-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for snowflake tests. #665
Add support for snowflake tests. #665
Conversation
@javornikolov Is there anything I need to change for this PR? |
Hi @nickpileggi947, thanks for your contribution! I need to look closer. One thing at first glimpse is that custom_libs content is supposed to be empty in the repo (it's intended for local tweaking). If a driver is not available in public artifact repo, we can upload it to our dedicated s3 place (I can take care of that). |
@javornikolov Appreciate the first set of feedback, I have pushed another commit that should fix those. Let me know if there is anything else you see that needs to be updated. |
@javornikolov just checking if there was anything else I needed to change on this PR? |
@javornikolov Just checking in again to see if you (or any other approver) is happy with this PR? |
dbfit-java/snowflake/src/main/java/dbfit/environment/SnowflakeEnvironment.java
Outdated
Show resolved
Hide resolved
dbfit-java/snowflake/src/main/java/dbfit/environment/SnowflakeEnvironment.java
Outdated
Show resolved
Hide resolved
dbfit-java/snowflake/src/main/java/dbfit/environment/SnowflakeEnvironment.java
Outdated
Show resolved
Hide resolved
dbfit-java/snowflake/src/main/java/dbfit/environment/SnowflakeProcedureParametersParser.java
Outdated
Show resolved
Hide resolved
@javornikolov All of the reviews have been closed and updated. |
dbfit-java/snowflake/src/main/java/dbfit/environment/SnowflakeEnvironment.java
Outdated
Show resolved
Hide resolved
dbfit-java/snowflake/src/main/java/dbfit/environment/SnowflakeEnvironment.java
Outdated
Show resolved
Hide resolved
dbfit-java/snowflake/src/main/java/dbfit/environment/SnowflakeEnvironment.java
Outdated
Show resolved
Hide resolved
dbfit-java/snowflake/src/main/java/dbfit/environment/SnowflakeEnvironment.java
Outdated
Show resolved
Hide resolved
dbfit-java/snowflake/src/main/java/dbfit/environment/SnowflakeProcedureParametersParser.java
Outdated
Show resolved
Hide resolved
dbfit-java/snowflake/src/main/java/dbfit/environment/SnowflakeProcedureParametersParser.java
Outdated
Show resolved
Hide resolved
@nickpileggi947, I added a few comments which are relatively small. The rest looks good, a few outstanding things:
|
@javornikolov I'll review and update these later today. But yea, we can squash these down to one large commit. And I would love to run the snowflake integration tests on TravisCI, but there is no free way to get a DB instance. |
aa6541a
to
e4f1486
Compare
@javornikolov Sorry for the late response, I have made all of the updates and squashed the commits to one. Let me know if you need anything else. |
Thank you @nickpileggi947! Looks good to me 👍 I am merging it. |
Add in support for snowflake DB. Integration tests are not coded since there is no easy to set up a free repeatable way for someone to test.
This resolves issue #642