-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support jsonb data type with Postgres database #671
Conversation
Hi @pascalsem, thank you for this contribution! Are you able to add some tests - they will run automatically on CI server PostGres, you don't need PostgreSQL locally to run them. |
In progress :) |
Hello @javornikolov I have updated pull request with missing components and tests to verify it works. It runs good in my local workstation (postgres 13.2 installed) but I can't figure out why it is failing in TravisCI. Is there any way for me to troubleshoot the execution ? Thanks :) |
Hi @pascalsem, maybe that from Travis CI build log would be helpful enough:
|
Perfect, thanks a lot I will be fixing those and run the task :) |
Hello again @javornikolov, I think I figured out why build is failing on Travis and not in local. Json data types in postgresql appeared since 9.2 but properly supported in 9.4 (https://www.postgresql.org/docs/9.4/datatype-json.html). So, do you think we can afford to upgrade version of postgresql to at least 9.4 ? It seems I could try with this documentation https://docs.travis-ci.com/user/database-setup/ Update : changed travis postgresql engine to 9.6 |
import dbfit.util.Direction; | ||
import dbfit.util.NameNormaliser; | ||
import dbfit.util.DatabaseObjectName; | ||
import dbfit.util.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We better use explicit imports
@javornikolov let me know if you think it's worth squashing some of these commits. |
Thanks, @MMatten, I already merged it keeping the original commits. |
Hello,
In my organization we are using dbfit version 3.2.0 and added support to jsonb data type in order to enable data insertion on such table columns.
Made same modifications on this pull request than in 3.2.0 PostgresEnvironment class.
As I am not using Gradle, I cannot perform tests from my workstation .... and have been done with dbfit and a PostgreSQL 9.6.10 database. Sorry for that.
The test page looks like this (assuming connection is established with db) :