Add ClientError Exception #9
Conversation
rodolfobandeira
force-pushed
the
add-bad-request-error
branch
from
74c53f3
to
e839a8a
Compare
rodolfobandeira
force-pushed
the
add-bad-request-error
branch
from
e839a8a
to
c5b9ae1
Compare
There was a problem hiding this comment.
Better, but doesn't work (see bug below).
The Faraday::ClientError raised is wrapping all errors 400-600, so not just HTTP 400 Bad Request (. See https://github.com/lostisland/faraday/blob/master/lib/faraday/response/raise_error.rb#L12). I suggest renaming BadRequest to ClientError to match.
README.md
Outdated
| @@ -146,6 +146,14 @@ See [#chart](https://iextrading.com/developer/docs/#chart) for detailed document | |||
|
|
|||
| If a symbol cannot be found an [IEX::Errors::SymbolNotFound](lib/iex/errors/symbol_not_found_error.rb) exception is raised. | |||
|
|
|||
| ### BadRequest | |||
|
|
|||
| All 400 bad request responses from IEX result in a BadRequest exception | |||
There was a problem hiding this comment.
Nitpick: change BadRequest to IEX::Errors::BadRequest as above and link it to the .rb file.
lib/iex/resources/chart.rb
Outdated
| @@ -21,6 +21,8 @@ def self.get(symbol, range = nil, options = {}) | |||
| end | |||
| rescue Faraday::ResourceNotFound => e | |||
| raise IEX::Errors::SymbolNotFoundError.new(symbol, e.response[:body]) | |||
| rescue Faraday::ClientError => e | |||
| raise IEX::Errors::BadRequestError, e.response[:body]['error'] | |||
There was a problem hiding this comment.
There's a bug here. You're passing in the text of the error, but the exception itself takes a response object. This should be e.response and the exception should be doing super e.response[:body]['error'].
spec/iex/resources/chart_spec.rb
Outdated
| end | ||
|
|
||
| it 'fails with BadRequestError' do | ||
| expect { subject }.to raise_error IEX::Errors::BadRequestError |
There was a problem hiding this comment.
You should be checking that the exception caught has a .response object and that its error message is the extracted message from the body.
|
Hey @dblock. Renamed to |
README.md
Outdated
| @@ -146,6 +146,14 @@ See [#chart](https://iextrading.com/developer/docs/#chart) for detailed document | |||
|
|
|||
| If a symbol cannot be found an [IEX::Errors::SymbolNotFound](lib/iex/errors/symbol_not_found_error.rb) exception is raised. | |||
|
|
|||
| ### ClientError | |||
|
|
|||
| All 400-600 bad request responses from IEX result in a [IEX::Errors::Client](lib/iex/errors/client_error.rb) exception. | |||
README.md
Outdated
| @@ -146,6 +146,14 @@ See [#chart](https://iextrading.com/developer/docs/#chart) for detailed document | |||
|
|
|||
| If a symbol cannot be found an [IEX::Errors::SymbolNotFound](lib/iex/errors/symbol_not_found_error.rb) exception is raised. | |||
|
|
|||
| ### ClientError | |||
|
|
|||
| All 400-600 bad request responses from IEX result in a [IEX::Errors::Client](lib/iex/errors/client_error.rb) exception. | |||
There was a problem hiding this comment.
They are not "bad request responses", say "All errors that return HTTP codes 400-600 result in ..."
lib/iex/version.rb
Outdated
| @@ -1,3 +1,3 @@ | |||
| module IEX | |||
| VERSION = '0.3.4'.freeze | |||
| VERSION = '0.3.5'.freeze | |||
spec/iex/resources/chart_spec.rb
Outdated
| @@ -72,4 +77,14 @@ | |||
| expect { subject }.to raise_error IEX::Errors::SymbolNotFoundError, 'Symbol INVALID Not Found' | |||
| end | |||
| end | |||
|
|
|||
| context 'with client error', vcr: { cassette_name: 'chart/badRequest' } do | |||
There was a problem hiding this comment.
Lets rename the badRequest file here to bad_option to match the name of the bad option.
|
@dblock All good! Thank YOU! |
|
Merged. |
close #2