@dblock => allow specta extras, and a simpler image folder setting #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| NSString *referenceImagesDirectory = [NSString stringWithFormat:@"%s", FB_REFERENCE_IMAGE_DIR]; | ||
| [[EXPExpectFBSnapshotTest instance] setReferenceImagesDirectory:referenceImagesDirectory]; | ||
| }); | ||
| setReferenceImageDir(FB_REFERENCE_IMAGE_DIR); |
There was a problem hiding this comment.
Should I be worried that this is something global? Should this be called something like setSnapshotTestsReferenceImageDir?
There was a problem hiding this comment.
this makes sense to me.
|
I made a bunch of semi-cosmetic comments, mostly about documentation. Update/fix the ones you want, I'll merge. |
| #import "SpectaUtility.h" | ||
| #import "SPTExample.h" | ||
|
|
||
| NSString *sanitizedTestPath(); |
There was a problem hiding this comment.
Also, does this have to be pre-declared like this?
|
I've pushed the changes. |
|
@orta, you sure you pushed any changes? Don't see any updates... |
|
oops, nope, have now. |
| ### App setup | ||
|
|
||
| * Specify the location of reference images with `setGlobalReferenceImageDir(FB_REFERENCE_IMAGE_DIR);` | ||
| * This is a global and needs to only be set once, as the test suite is ran alphabetically, you should ensure it's in the the first test suite that loads. |
There was a problem hiding this comment.
Still think that this method is just weird and flaky. I'll play with this.
|
Merging, thx. |
dblock
added a commit
that referenced
this pull request
Jan 18, 2014
@dblock => allow specta extras, and a simpler image folder setting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to #1 I've simplified the API for setting the images directory to a c function that feels a lot like the rest of spectra. So you do
setReferenceImageDir("blah")like expected, and the docs now state that this only has to be done once.In reference to #2 I've extended the API for expecta if we see that you've included Specta in CocoaPods, this is a weak dependency because expecta is built to work without Specta, and so should our library. If you don't have it installed it will always fail.
This means we offer: