Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update gridhelper to work with aframe 0.4.0 #3

Merged
merged 8 commits into from
Dec 21, 2016
Merged

update gridhelper to work with aframe 0.4.0 #3

merged 8 commits into from
Dec 21, 2016

Conversation

kfarr
Copy link
Contributor

@kfarr kfarr commented Dec 18, 2016 •
edited
Loading

  • colors are set in initial constructor, not as method
  • steps has now been replaced with divisions
  • upgraded aframe references to 0.4.0

note: i could not get the example to build properly on my pc, so testing would be appreciate before merging

relevant reading: https://github.com/mrdoob/three.js/commits/master/src/extras/helpers/GridHelper.js

@dbradleyfl dbradleyfl merged commit 5444f06 into dbradleyfl:master Dec 21, 2016
@dbradleyfl dbradleyfl mentioned this pull request Dec 21, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kfarr @dbradleyfl