Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using cl functions issue #30

Merged
merged 1 commit into from
Dec 5, 2015
Merged

Fix using cl functions issue #30

merged 1 commit into from
Dec 5, 2015

Conversation

syohex
Copy link
Contributor

@syohex syohex commented Nov 13, 2015

eval-when-compile for cl.el is not necessary because this package uses
cl.el functions. And switch from cl.el to cl-lib.el, because loading cl.el
at runtime causes byte-compile warning and using cl-lib.el is better than
using cl.el.

@ghost
Copy link

ghost commented Nov 16, 2015

Just a heads up that recent Emacs warns requiring cl at runtime.

(require 'cl-lib) and changing them to the prefixed cl-gensym, cl-remove-if, ... might be a better approach. It may also need cl-lib 0.5 as a listed dependency to accommodate old Emacs versions.

eval-when-compile for cl.el is not necessary because this package uses
cl.el functions. And switch from cl.el to cl-lib.el, because loading cl.el
at runtime causes byte-compile warning and using cl-lib.el is better than
using cl.el.
@syohex syohex changed the title Load cl.el at not only compile time but also runtime Fix using cl functions issue Nov 16, 2015
@syohex
Copy link
Contributor Author

syohex commented Nov 16, 2015

Thanks for comment. I have updated.

@dbrock
Copy link
Owner

dbrock commented Dec 5, 2015

Looks good, thanks!

dbrock added a commit that referenced this pull request Dec 5, 2015
Fix using cl functions issue
@dbrock dbrock merged commit 4cdacc1 into dbrock:master Dec 5, 2015
@syohex syohex deleted the cl branch December 5, 2015 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants