fix segfault triggered in fuzzy testing (thanks Dennis Felsing for reporting)

dbry · dbry · commit 5d4e146c9f40 · 2014-11-30T18:12:50.000-08:00
diff --git a/src/open_utils.c b/src/open_utils.c
@@ -681,6 +681,8 @@ static int read_metadata_buff (WavpackMetadata *wpmd, unsigned char *blockbuff,
     }
 
     if (wpmd->id & ID_ODD_SIZE) {
+        if (!wpmd->byte_length)         // odd size and zero length makes no sense
+            return FALSE;
         wpmd->id &= ~ID_ODD_SIZE;
         wpmd->byte_length--;
     }

Original file line number	Diff line number	Diff line change
`@@ -681,6 +681,8 @@ static int read_metadata_buff (WavpackMetadata wpmd, unsigned char blockbuff,`
`681`	`681`	`}`
`682`	`682`
`683`	`683`	`if (wpmd->id & ID_ODD_SIZE) {`
	`684`	`+ if (!wpmd->byte_length) // odd size and zero length makes no sense`
	`685`	`+ return FALSE;`
`684`	`686`	`wpmd->id &= ~ID_ODD_SIZE;`
`685`	`687`	`wpmd->byte_length--;`
`686`	`688`	`}`