[#1004] create module, package structure and pom for data integration module #1015
Conversation
merando
changed the title
| import org.gradoop.flink.model.api.functions.TransformationFunction; | ||
|
|
||
| /** | ||
| * Each a given edge label each edge gets its label changed + source and target |
There was a problem hiding this comment.
Is there a typo? Or my English is not "the yellow from the egg" ^^ Maybe: An edge transformation that swaps the source and target of an edge with a given label and renames it.
| public class InvertEdges implements TransformationFunction<Edge> { | ||
|
|
||
| /** | ||
| * label of the edges that should be inverted |
There was a problem hiding this comment.
Since we create and publish javadoc, please use sentences like The label of the edges that should be inverted.
| private final String newLabel; | ||
|
|
||
| /** | ||
| * The constructor. |
There was a problem hiding this comment.
Constructs a new InvertEdges edge transformation function.
| /** | ||
| * The constructor. | ||
| * | ||
| * @param forEdgeLabel - the label if the edges that should be inverted |
There was a problem hiding this comment.
Typo ->if<- and the - is not necessary because it will be inserted automatically at javadoc creation.
...p-data-integration/src/main/java/org/gradoop/dataintegration/transformation/InvertEdges.java
Show resolved
Hide resolved
| */ | ||
| public class InvertEdgesTest extends GradoopFlinkTestBase { | ||
|
|
||
| @Test(expected = NullPointerException.class) |
There was a problem hiding this comment.
Please provide a short javadoc at each test because we plan to enable checkstyle for test classes in the future.
| } | ||
|
|
||
| @Test | ||
| public void testInvert() throws Exception { |
There was a problem hiding this comment.
I think a test for the inverting is missing. Only the renaming is tested. Note that every call to count() is a own executed plan aik.
There was a problem hiding this comment.
Good point, I will add one.
| List<Edge> newEdges = new ArrayList<>(); | ||
| invertedEdgeGraph | ||
| .getEdgesByLabel(invertedLabel) | ||
| .output(new LocalCollectionOutputFormat<>(newEdges)); |
There was a problem hiding this comment.
There is a missing ExecutionEnvironment.execute() after those, the vertices and newEdges collections will both be empty.
| */ | ||
| List<Vertex> vertices = new ArrayList<>(); | ||
| invertedEdgeGraph.getVertices() | ||
| .filter(new And<>(new ByLabel<>("Person"), new ByLabel<>("Tag"))) |
There was a problem hiding this comment.
This should be an Or<> instead, this filter will accept no vertices.
| String sourceName = idMap.get(e.getSourceId()); | ||
| String targetName = idMap.get(e.getTargetId()); | ||
|
|
||
| Assert.assertTrue("source: " + sourceName + " | target: " + targetName, |
There was a problem hiding this comment.
This assert will always fail (since the idMap is empty and Collection.contains(null) is always false), but is never actually reached, since newEdges is empty.
|
Oh - you are absolutely right. @merando has to provide a Bug ticket and PR for that. If three people have not seen that, then the fourth must be smarter ^^ |
…integration module (dbs-leipzig#1015) * fixes [dbs-leipzig#1004] created module, package structure and pom * fixes [dbs-leipzig#1009] added invert edges structural transformation
No description provided.