Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1111] added print operator to TemporalGraph and TemporalGCollection #1377

Merged

Conversation

ChrizZz110
Copy link
Contributor

added print operator to TemporalGraph and TemporalGraphCollection

  • also added a missing log4j config in gradoop-temporal tests

…GraphCollection + also added a missing log4j config in gradoop-temporal tests
@ChrizZz110 ChrizZz110 requested review from galpha and p-f August 28, 2019 08:36
Copy link
Contributor

@timo95 timo95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -0,0 +1,11 @@
# Set root logger level to OFF to not flood build logs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really part of this PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, looks like this was accidentally added

Copy link
Collaborator

@p-f p-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please remove the log4j config file

@@ -0,0 +1,11 @@
# Set root logger level to OFF to not flood build logs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, looks like this was accidentally added

Copy link
Contributor

@galpha galpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@galpha galpha merged commit 62feb81 into dbs-leipzig:develop Sep 2, 2019
galpha pushed a commit that referenced this pull request Oct 17, 2019
…tion + also added a missing log4j config in gradoop-temporal tests (#1377)

fixes #1111
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants