[#838] add random edge sampling #839
Conversation
|
|
||
| /** | ||
| * seed for the random number generator | ||
| * if seed is null, the random generator is created without seed |
There was a problem hiding this comment.
the seed can't be null since you are using a primitive type
| * Creates new RandomEdgeSampling instance. | ||
| * | ||
| * @param sampleSize relative sample size | ||
| * @param randomSeed random seed value (can be {@code null}) |
There was a problem hiding this comment.
again, can't be null. to do so you would need 'Long' instead of 'long'. But the later code snippets indicate that your are refering to '0' instead of 'null' so a fix of the java doc should be sufficient
| * and their associated source- and target-vertices. No unconnected vertices will retain in the | ||
| * sampled graph. | ||
| */ | ||
| public class RandomEdgeSampling implements UnaryGraphToGraphOperator { |
There was a problem hiding this comment.
Why can't this be implemented as a FilterFunction which then is applied in a edgeInducedSubgraph call?
Isn't this generalizable for Vertices also?
There was a problem hiding this comment.
There will be more sampling methods in which either vertices or edges or both are filtered.
In this special case, it may be thought of a simple filter function however it is not
the case in all samplings. In some sampling, it should be an unary graph to graph operator. So to have a bundle of similar algorithms, we just call all of them samplings.
For example, just think of PageRankSampling.
There was a problem hiding this comment.
I also corrected the comments regarding the random seed.
So it can be zero not null.
…radoop into #838_RandomEdgeSampling
fixes #838