Oracle producer add missing functions

lib/SQL/Translator/Producer/Oracle.pm

@@ -95,7 +95,7 @@ $DEBUG   = 0 unless defined $DEBUG;
 
 use base 'SQL::Translator::Producer';
 use SQL::Translator::Schema::Constants;
-use SQL::Translator::Utils qw(header_comment);
+use SQL::Translator::Utils qw(header_comment batch_alter_table_statements);
 
 my %translate  = (
     #
@@ -695,6 +695,73 @@ sub create_field {
 
 }
 
+sub batch_alter_table {
+  my ($table, $diff_hash, $options) = @_;
+
+  my %fks_to_alter;
+  my %fks_to_drop = map {
+    $_->type eq FOREIGN_KEY
+              ? ( $_->name => $_ )
+              : ( )
+  } @{$diff_hash->{alter_drop_constraint} };
+
+  my %fks_to_create = map {
+    if ( $_->type eq FOREIGN_KEY) {
+      $fks_to_alter{$_->name} = $fks_to_drop{$_->name} if $fks_to_drop{$_->name};
+      ( $_->name => $_ );
+    } else { ( ) }
+  } @{$diff_hash->{alter_create_constraint} };
+
+  my @drop_stmt;
+  if (scalar keys %fks_to_alter) {
+    $diff_hash->{alter_drop_constraint} = [
+      grep { !$fks_to_alter{$_->name} } @{ $diff_hash->{alter_drop_constraint} }
+    ];
+
+    @drop_stmt = batch_alter_table($table, { alter_drop_constraint => [ values %fks_to_alter ] }, $options);
+
+  }
+
+  my @stmts = batch_alter_table_statements($diff_hash, $options);
+
+  # rename_table makes things a bit more complex
+  my $renamed_from = "";
+  $renamed_from = quote($diff_hash->{rename_table}[0][0]->name)
+    if $diff_hash->{rename_table} && @{$diff_hash->{rename_table}};
+
+  return unless @stmts;
+  # Just zero or one stmts. return now
+  return (@drop_stmt,@stmts) unless @stmts > 1;
+
+  # Now strip off the 'ALTER TABLE xyz' of all but the first one
+
+  my $table_name = quote($table->name);
+
+  my $re = $renamed_from
+         ? qr/^ALTER TABLE (?:\Q$table_name\E|\Q$renamed_from\E) /
+            : qr/^ALTER TABLE \Q$table_name\E /;
+
+  my $first = shift  @stmts;
+  my ($alter_table) = $first =~ /($re)/;
+
+  my $padd = " " x length($alter_table);
+
+  return @drop_stmt, join( ",\n", $first, map { s/$re//; $padd . $_ } @stmts);
+
+}
+
+sub drop_table {
+  my ($table, $options) = @_;
+
+  return (
+    # Drop (foreign key) constraints so table drops cleanly
+    batch_alter_table(
+      $table, { alter_drop_constraint => [ grep { $_->type eq 'FOREIGN KEY' } $table->get_constraints ] }, $options
+    ),
+    'DROP TABLE ' . quote($table),
+  );
+}
+
 sub alter_drop_constraint {
     my ($c, $options) = @_;
 

t/54-oracle-alter-constraint.t

@@ -9,7 +9,7 @@ use SQL::Translator;
 use SQL::Translator::Diff;
 
 BEGIN {
-    maybe_plan(4, 'SQL::Translator::Parser::YAML',
+    maybe_plan(6, 'SQL::Translator::Parser::YAML',
                   'SQL::Translator::Producer::Oracle');
 }
 
@@ -50,6 +50,10 @@ ok($diff, 'Diff generated.');
 
 like($diff, '/ALTER TABLE d_operator DROP CONSTRAINT foo_unique/', 'DROP constraint foo_unique generated');
 
-like($diff, '/ALTER TABLE d_operator DROP CONSTRAINT other_check/', 'DROP constraint other_check generated');
+like($diff, '/DROP CONSTRAINT other_check/', 'DROP constraint other_check generated');
 
 like($diff, '/ADD CONSTRAINT other_check CHECK \(other BETWEEN 100 and 99999\)/', 'ADD check constraint generated');
+
+like($diff, '/ALTER TABLE supplier DROP FOREIGN KEY fk_customer/', 'DROP Foreign key constraint generated');
+
+like($diff, '/DROP TABLE customer/', 'DROP TABLE customer generated');

t/data/oracle/schema_diff_d.yaml

@@ -71,3 +71,52 @@ schema:
             - 5
       name: d_operator
       order: 11
+    supplier:
+      constraints:
+        - fields: cust_id
+          name: fk_customer
+          reference_table: customer
+          reference_fields: 
+            - customer_id
+          type: FOREIGN KEY
+      fields:
+        id:
+          data_type: integer
+          is_nullable: 0
+          is_primary_key: 1
+          size: 11
+          name: id
+          order: 62
+        cust_id:
+          data_type: integer
+          is_nullable: 1
+          is_primary_key: 0
+          size: 11
+          name: cust_id
+          order: 63
+        supplier_name: 
+          data_type: nvarchar2
+          is_nullable: 0
+          is_primary_key: 0
+          size: 256
+          name: supplier_name
+          order: 64
+      name: supplier
+    customer:
+      fields:
+        customer_id:
+          data_type: integer
+          is_nullable: 0
+          is_primary_key: 1
+          size: 11
+          name: customer_id
+          order: 65
+        customer_name:
+          data_type: nvarchar2
+          is_nullable: 0
+          is_primary_key: 0
+          size: 256
+          name: customer_name
+          order: 66
+      name: customer
+      order: 12

t/data/oracle/schema_diff_e.yaml

@@ -68,3 +68,27 @@ schema:
             - 5
       name: d_operator
       order: 11
+    supplier:
+      fields:
+        id:
+          data_type: integer
+          is_nullable: 0
+          is_primary_key: 1
+          size: 11
+          name: id
+          order: 62
+        cust_id:
+          data_type: integer
+          is_nullable: 1
+          is_primary_key: 0
+          size: 11
+          name: cust_id
+          order: 63
+        supplier_name: 
+          data_type: nvarchar2
+          is_nullable: 0
+          is_primary_key: 0
+          size: 256
+          name: supplier_name
+          order: 65
+      name: supplier