mysql-parser: Set missing field's collate to table's collate #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer MariaDB exports don;t set the field's collate if it is the same a the table's collate. To prevent huge diffs between exports of the old and new version, set missing field's collate to the table's collate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer MariaDB exports don't set the field's collate if it is the same as the table's collate. To prevent huge diffs between exports of the old and new version, set missing field's collate to the table's collate.
The table's option parsing is moved up so the collate can be extracted before parsing all the fields.
There might be a similar issue with the charset, but I haven't seen that with my datasets.