Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix psql drop constraint issue on primary keys #20

Conversation

throughnothing
Copy link
Contributor

This attempts to fix an issue when dropping a primary key in PostgreSQL.

Currently, the code handles foreign key dropping fine (by dropping the tablename_fieldname_fkey constraint), but ignores the case of primary keys (tablename_pkey constraint). This adds logic to handle that.

I have tested this manually and it fixes the issue I was having using DBIC::DeploymentHandler to generate a migration that changes the primary key column on a table. Additionally, all existing tests in SQL::Translator pass with this change.

I have added some very simple tests, based around the FOREIGN_KEY tests I found in t/47postgrs-producer.t, and I'd love some feedback on those as well. Are there other places I should be adding tests?

@ribasushi
Copy link
Contributor

Finally applied as bc9b1c11f. Sorry for the delay.

@ribasushi ribasushi closed this Mar 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants