Fix psql drop constraint issue on primary keys #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to fix an issue when dropping a primary key in PostgreSQL.
Currently, the code handles foreign key dropping fine (by dropping the
tablename_fieldname_fkey
constraint), but ignores the case of primary keys (tablename_pkey
constraint). This adds logic to handle that.I have tested this manually and it fixes the issue I was having using
DBIC::DeploymentHandler
to generate a migration that changes the primary key column on a table. Additionally, all existing tests inSQL::Translator
pass with this change.I have added some very simple tests, based around the FOREIGN_KEY tests I found in
t/47postgrs-producer.t
, and I'd love some feedback on those as well. Are there other places I should be adding tests?