Re-worked Changes file #23
Conversation
Sadly, this doesn't validate because of a missing release date for version 0.08_03. It will be future compatible, though, when the release date becomes an optional element.
|
Can you elaborate a bit more on what are the incentives to target a particular spec? I am not trying to reject the patch outright, merely commenting that it changes a lot of existing Changelog structure for no apparent reason. Hence looking for clarification. Cheers |
|
Not sure what you mean by "no apparent reason" since the commit message states the reason -- i.e. to adhere to CPAN::Changes spec -- but allow me to elucidate as best I can :) The point is to create a human readable & machine parsable changelog using a format widely used by existing distributions already on CPAN. The end result allows programmatic access to the data so that changelogs can be read from (think "most recent feed" for e.g.), written to and updated (think automated tools to update the version & release date in the changelog, for e.g.) If you haven't already, please checkout http://changes.cpanhq.org/ for a bit more info. I know the unified diff looks a wee-bit messy, but if you view the files side-by-side, you'll see the changes are actually relatively minor:
And that's basically all. If there are other questions, let me know! Cheers :) |
|
Fwiw I am for it.
|
|
Went ahead and reimplemented it with the one caveat that instead of standardizing on extra whitespace we standardize on less (since that's mostly how it's done in the rest of the file. Thanks @bricas! |
|
For the record I was going to reject this patch with no changes, but never got around to it due to my chronic suckiness. Anyway, what's done is done, just relinking the objections here to hopefully prevent future blind applications of similar mindless patches. The Changes spec as it stands is close to unusable as detailed here: metacpan/metacpan-web#948 Cheers |
I've re-worked the Changes file to be more CPAN::Changes::Spec-like. As mentioned in my commit, it doesn't yet validate due to a missing release date, though it's very close!