fix Producer::SQLite::batch_alter_table rename field

[SysPete]

rename_field is ignored by Producer::SQLite and the existing tests have:

SELECT ... physical_description FROM person"

which should be:

SELECT ... description FROM person"

Patches address this and try to make some of the code (mostly inside batch_alter_table) more readable.

[SysPete]

Further testing with my new DBIC distro ::Versioned::Inline has proved that this is a real bug so reopening. Will hopefully have time in the next few days to add some useful test to prove this.

[SysPete]

Further explanation on the issue:

SQLT::Diff works fine for SQLite with column renames as long as there are no rows in the table and produces perfectly good SQL for creating the replacement table. The problem is that the code for moving the data from old to new table is completely broken. That is what this patch set tries to fix.

[frioux]

Could you write a test that fails before the patch and passes after? That would help.

[SysPete]

I've rehacked this into a single commit + supplied test that fails against master.

[coveralls]

Coverage increased (+0.06%) when pulling 55e4835 on SysPete:fixes/sqlite_rename_field into cb9bbc6 on dbsrgits:master.

[SysPete]

I've removed some unnecessary changes from the diff which makes it much cleaner and rebased against master. I'm using this updated batch_alter_table method botched into DBIx::Class::Schema::Versioned::Inline to fixup SQLite upgrade problems which adds quite a few more tests in addition to the SQLT ones and all is well there.
Any chance of seeing this in the next release?

[coveralls]

Coverage increased (+0.04%) when pulling 05c9b80 on SysPete:fixes/sqlite_rename_field into cb9bbc6 on dbsrgits:master.

[coveralls]

Coverage increased (+0.04%) when pulling 05c9b80 on SysPete:fixes/sqlite_rename_field into cb9bbc6 on dbsrgits:master.

[dbsrgits-sync]

Will look at this later today I hope to see if we can get it merged.
Thanks!

-frew
(sent from my HTC 5c Galaxy megaphone, please pardon my brevity)

[ilmari]

No need for the if here, the for loop will just execute zero times if the array is empty.

[coveralls]

Coverage increased (+0.02%) when pulling 768f5d9 on SysPete:fixes/sqlite_rename_field into cb9bbc6 on dbsrgits:master.

[SysPete]

Unnecessary ifs removed and loops replaced with map and delete hash slice.

[SysPete]

ilmari> SysPete: I just noticed, you're quoting $temp_table_name twice
fixed - my bad.

[coveralls]

Coverage increased (+0.02%) when pulling 0ce3181 on SysPete:fixes/sqlite_rename_field into cb9bbc6 on dbsrgits:master.