Provide default index names for SQLite #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch, it looks good. Could you please add a test case as |
The allegedly default names were never used causing the first index created without a name to fail and subsequent indices to be named 02, 03, 04... This uses the table name with '_idx' appended as the default, similar to the PostgreSQL producer.
andrewgregory
force-pushed
the
sqlite-index
branch
from
e3201f7
to
e51d5c4
Compare
|
Updated with test case. |
|
Thanks for the patch and tests. I've manually merged it as 2491a46. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The allegedly default names were never used causing the first index
created without a name to fail and subsequent indices to be named 02,
03, 04... This uses the table name with '_idx' appended as the default,
similar to the PostgreSQL producer.