improve add_trigger consistency between producers #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Producer::SQLite and Producer::MySQL to only wrap the trigger action in "BEGIN...END" when the user has not already done so, bringing them in line with other producers and the add_trigger documentation. Fixes dbsrgits#46. Signed-off-by: Andrew Gregory <andrew.gregory.8@gmail.com>
|
Did you mean to say /s instead of /m? /s makes '.' match newlines, /m makes '$' and '^' match before and after newlines respectively. If you meant /s then yes I think that makes sense. |
Yes, silly typo. I expanded the regex a little more and merged your changes as e533bcddea Please let me know if I missed anything, and thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Producer::SQLite and Producer::MySQL to only wrap the trigger
action in "BEGIN...END" when the user has not already done so, bringing
them in line with other producers and the add_trigger documentation.
Fixes #46.
Signed-off-by: Andrew Gregory andrew.gregory.8@gmail.com