Fixes Bug #63814: Allow for index creation with USING and WHERE keywords...

[SPodjasek]

... supplied as add_index options

[SPodjasek]

Current PostgreSQL version (9.4) allows some other options to be set:

CREATE [ UNIQUE ] INDEX [ CONCURRENTLY ] [ name ] ON table_name [ USING method ]
    ( { column_name | ( expression ) } [ COLLATE collation ] [ opclass ] [ ASC | DESC ] [ NULLS { FIRST | LAST } ] [, ...] )
    [ WITH ( storage_parameter = value [, ... ] ) ]
    [ TABLESPACE tablespace_name ]
    [ WHERE predicate ]

but nobody asked for them for now

[ilmari]

If you include the leading space when setting the value above, you can get rid of the ugly conditionals here.

[ilmari]

Not a prerequisite for merging this, but it would be nice to support this in Parser::PostgreSQL as well. The grammar already parses the clauses it just doesn't store them in the Schema::Index object

[ilmari]

It's storing it in the data structure it builds during parsing, but it's not propagating that in the $table->add_index call.

[ribasushi]

@SPodjasek @ilmari This is also likely related to https://rt.cpan.org/Ticket/Display.html?id=101704 and frioux/DBIx-Class-DeploymentHandler#32 (comment)

[ilmari]

@ribasushi No, that's about specifying an explicit conversion when changing column types, it just happens to also use the USING keyword.

[SPodjasek]

My Parser::PostgreSQL changes lack support of function fields in indexes, but it is also an issue with Parser::DBI::PostgreSQL (as stated in line 144 there)

[ilmari]

Thank you, merged with minor tweaks as 5b36314 and 9c05d80.