some more optimizations for add_field #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15-05-11@16:58:43
(ribasushi) just optimize for "minimal logical diff", and
ignore the urge to "strive for elegance"
Getting the names of fields is only needed when adding a field with a pre-determined order value. For all other cases that is wasted time.
The code that determines/checks the value of order for the new field needs all existing fields, but does not depend on their order at all, thus switching from get_fields to _fields speeds things up a bit.
|
IIRC the gains were substantial, provided the table is large enough. To get actual numbers i'd need to look up the actual case though. Pleanning to get around to that next week. What exactly does double-digit gain mean? As for the duplicate thing, i think it'll be best if i simply make a test for it and have it retain behavior on that. I think it'll be possible to get both that, and the speed-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These combine with #54