Update JSON, YAML, & SQLite parsers to track table comments; fix YAML & JSON producers' table comments #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both the JSON and YAML producers called the Table and Field comments method in list context while constructing a hash, assuming they would return a single value. They don't. In list context the comments methods return a list of comments. This led to "odd number of hash element" errors if the comments method returned an even number of elements. In scalar context the comments methods return a string composed of the concatenation of comments. This context was explicitly used when producing procedure comments. However, since the JSON and YAML formats support arrays, their producers should output the comments as arrays to avoid loss of information. To that end, all comments output are now encoded as arrays.
|
Cleaning up here, this is already implemented in master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SQLite, YAML & JSON parsers (trivially) didn't track table comments. I've added that.
The YAML and JSON producers should have output comments as arrays; for table and field comments, they could croak or generate incorrect output if there was an even number of comments. For procedures, the comments were output as a concatenated string instead of an array.