Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sybase: fix datatype mapping; IDENTITY #66

Closed

Conversation

perlpunk
Copy link
Contributor

Datatype mapping must also be done for identity fields
IDENTITY comes after the datatype, not before

datatype mapping must also be done for identity fields
IDENTITY comes after the datatype, not before
@perlpunk
Copy link
Contributor Author

There are two other issues:

  1. DBIC deployment_statements can receive a list of statements. The sybase sqlt producer returns a single string which is then splitted by DBIC. The producer should return a list in list context. I made the same change in the postgres producer some years ago.
  2. In Sybase, you can't deactivate constraint checks. So depending on the order of the CREATE statements it will fail because of missing tables for foreign keys. A solution would be to add the foreign key creation to the end of the statements.

Maybe I should do this all in one pull request?

@perlpunk perlpunk closed this Aug 26, 2015
@perlpunk
Copy link
Contributor Author

see #67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant