feat: add quoting support

[cstruct]

Add quoting support both where Presto and Hive style is used.

From request by @nicor88

[nicor88]

@cstruct could you fix the linting issues?

[cstruct]

Yes, of course! I'll fix it tomorrow when I'm home again.

[cstruct]

Sorry for the wait! Forgot to do it during the weekend :)

[nicor88]

@cstruct I tested this PR, and somehow this changes breaks our iceberg implementation.

Here the error log that I'm getting:

An error occurred (InvalidRequestException) when calling the StartQueryExecution operation: line 2:22: mismatched input '"lakehouse"' expecting

For what I can see the first part where it breaks is the drop staement.
e.g.

that should be rendered as drop table if existslakehouse.example_iceberg``

[cstruct]

@nicor88 I'm not familiar with the iceberg implementation but I pushed a commit with a guess for a fix. Could you try again? If this doesn't work I'll have to create a test setup and do some proper debugging.

[nicor88]

@cstruct we can help you out, most of the code is in helpers_iceberg and in incremental (not sure if it's needed here, it might be needed too).

As you can see we have a custom drop for iceberg, as we don't use the general drop overwrite, the reason behind is that a drop table in iceberg lead to actual data deletion in S3, but this is not valid in the other cases.

[cstruct]

@nicor88 alright it doesn't seem to involved. Unfortunately I've managed to bork my local python env, might have time to fix and test later today otherwise later this week. For the time being I pushed a commit that changes to Hive style where dropping and creating external tables in helpers_iceberg which I know are required. If you have the time and feel for it you can give it a try again otherwise I'll look into it later.

[cstruct]

For those that are interested the reason this broke support for iceberg tables is that previously relation.quote_character was set to an empty string causing no quoting. This PR updates it to the Presto quote char " causing all identifiers to be quoted with it unless you explicitly call relation.render_hive() instead of implicit relation.__str__() or explicit relation.render().

[nicor88]

@cstruct any plan to move this forward?

[mattiamatrix]

Please get the latest changes from main and update the PR title to align with conventional commits style

[cstruct]

Yes, I do plan to revisit this PR when I have the time and energy to do so, I can't give any guarantees as to when that will happen though. If you feel that you do not want to wait for that, the Allow edits and access to secrets by maintainers is checked so any maintainer can pick up form where I left off.

[BrechtDeVlieger]

What is still to be done for this PR to be merged? Are the latest changes to helpers_iceberg tested @nicor88? I'm willing to continue the work on this if need be. Just not sure if the iceberg tests are still failing or not..

[nicor88]

@BrechtDeVlieger helper_iceberg doesn't exist anymore, this PR require a rebase with main and a fix for supporting iceberg. We don't have specific Integration tests to cover iceberg, you might want to use a specific model to test this branch with it.