feat: add quoting support

README.md

@@ -191,25 +191,6 @@ Due to the nature of AWS Athena, not all core dbt functionality is supported.
 The following features of dbt are not implemented on Athena:
 * Snapshots
 
-#### Known issues
-
-* Quoting is not currently supported
-  * If you need to quote your sources, escape the quote characters in your source definitions:
-
-  ```yaml
-  version: 2
-
-  sources:
-    - name: my_source
-      tables:
-        - name: first_table
-          identifier: "first table"       # Not like that
-        - name: second_table
-          identifier: "\"second table\""  # Like this
-  ```
-
-* Tables, schemas and database should only be lowercase
-
 ### Contributing
 
 This connector works with Python from 3.7 to 3.10.

dbt/adapters/athena/relation.py

@@ -13,9 +13,24 @@ class AthenaIncludePolicy(Policy):
 
 @dataclass(frozen=True, eq=False, repr=False)
 class AthenaRelation(BaseRelation):
-    quote_character: str = ""
+    quote_character: str = '"'  # Presto quote character
     include_policy: Policy = AthenaIncludePolicy()
 
+    def render_hive(self):
+        """
+        Render relation with Hive format. Athena uses Hive format for some DDL statements.
+
+        See:
+        - https://aws.amazon.com/athena/faqs/ "Q: How do I create tables and schemas for my data on Amazon S3?"
+        - https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL
+        """
+
+        old_value = self.quote_character
+        object.__setattr__(self, "quote_character", "`")  # Hive quote char
+        rendered = self.render()
+        object.__setattr__(self, "quote_character", old_value)
+        return rendered
+
 
 class AthenaSchemaSearchMap(Dict[InformationSchema, Dict[str, Set[Optional[str]]]]):
     """A utility class to keep track of what information_schema tables to

dbt/include/athena/macros/adapters/relation.sql

@@ -3,6 +3,9 @@
     {%- do adapter.clean_up_table(relation.schema, relation.table) -%}
   {% endif %}
   {% call statement('drop_relation', auto_begin=False) -%}
-    drop {{ relation.type }} if exists {{ relation }}
+    drop {{ relation.type }} if exists
+      {%- if relation.type == 'table' %} {{ relation.render_hive() -}}
+      {%- else %} {{ relation -}}
+      {%- endif -%}
   {%- endcall %}
 {% endmacro %}

dbt/include/athena/macros/adapters/schema.sql

@@ -0,0 +1,12 @@
+{% macro default__create_schema(relation) -%}
+  {%- call statement('create_schema') -%}
+    create schema if not exists {{ relation.without_identifier().render_hive() }}
+  {% endcall %}
+{% endmacro %}
+
+
+{% macro default__drop_schema(relation) -%}
+  {%- call statement('drop_schema') -%}
+    drop schema if exists {{ relation.without_identifier().render_hive() }} cascade
+  {% endcall %}
+{% endmacro %}

dbt/include/athena/macros/materializations/models/helpers.sql

@@ -2,6 +2,6 @@
     {%- set format = config.get('format', default=default_value) -%}
 
     {% call statement('set_table_classification', auto_begin=False) -%}
-        alter table {{ relation }} set tblproperties ('classification' = '{{ format }}')
+        alter table {{ relation.render_hive() }} set tblproperties ('classification' = '{{ format }}')
     {%- endcall %}
 {%- endmacro %}

dbt/include/athena/macros/materializations/models/helpers_iceberg.sql

@@ -1,5 +1,5 @@
 {% macro drop_iceberg(relation) -%}
-  drop table if exists {{ relation }}
+  drop table if exists {{ relation.render_hive() }}
 {% endmacro %}
 
 {% macro create_table_iceberg(relation, old_relation, tmp_relation, sql) -%}
@@ -77,7 +77,7 @@
 
   {%- set dest_columns_with_type_csv = dest_columns_with_type | join(', ') -%}
 
-  CREATE TABLE {{ relation }} (
+  CREATE TABLE {{ relation.render_hive() }} (
     {{ dest_columns_with_type_csv }}
   )
   {%- if partitioned_by is not none %}

dbt/include/athena/macros/materializations/seeds/helpers.sql

@@ -14,7 +14,7 @@
   {%- set s3_data_naming = model['config'].get('s3_data_naming', target.s3_data_naming) -%}
 
   {% set sql %}
-    create external table {{ this.render() }} (
+    create external table {{ this.render_hive() }} (
         {%- for col_name in agate_table.column_names -%}
             {%- set inferred_type = adapter.convert_type(agate_table, loop.index0) -%}
             {%- set type = column_override.get(col_name, inferred_type) -%}

tests/unit/constants.py

@@ -3,3 +3,4 @@
 DATABASE_NAME = "test_dbt_athena"
 BUCKET = "test-dbt-athena-test-delete-partitions"
 AWS_REGION = "eu-west-1"
+TABLE_NAME = "test-table"

tests/unit/test_relation.py

@@ -0,0 +1,22 @@
+from dbt.adapters.athena.relation import AthenaRelation
+
+from .constants import DATA_CATALOG_NAME, DATABASE_NAME, TABLE_NAME
+
+
+class TestAthenaRelation:
+    def test_render_hive_uses_hive_style_quotation(self):
+        relation = AthenaRelation.create(
+            identifier=TABLE_NAME,
+            database=DATA_CATALOG_NAME,
+            schema=DATABASE_NAME,
+        )
+        assert relation.render_hive() == f"`{DATABASE_NAME}`.`{TABLE_NAME}`"
+
+    def test_render_hive_resets_quote_character_after_call(self):
+        relation = AthenaRelation.create(
+            identifier=TABLE_NAME,
+            database=DATA_CATALOG_NAME,
+            schema=DATABASE_NAME,
+        )
+        relation.render_hive()
+        assert relation.render() == f'"{DATABASE_NAME}"."{TABLE_NAME}"'