[Fix] Limit check-source-has-tests-by-group hook to yaml files

[katieclaiborne]

In #91, it was my commit that inadvertently added sql to the types_or list for the check-source-has-tests-by-group.

I was naively pattern-matching based on the check-model-has-tests-by-group hook, and didn't think through the implications of the addition.

As we've started to use the new hook, we've run into an AttributeError that occurs when the hook is run over .sql files.

Check the source tests by test group.....................................Failed
- hook id: check-source-has-tests-by-group
- exit code: 1

Traceback (most recent call last):
  File "/home/runner/.cache/pre-commit/repov8wo5h41/py_env-python3/bin/check-source-has-tests-by-group", line 8, in <module>
    sys.exit(main())
  File "/home/runner/.cache/pre-commit/repov8wo5h41/py_env-python3/lib/python3.10/site-packages/pre_commit_dbt/check_source_has_tests_by_group.py", line 85, in main
    return check_test_cnt(
  File "/home/runner/.cache/pre-commit/repov8wo5h41/py_env-python3/lib/python3.10/site-packages/pre_commit_dbt/check_source_has_tests_by_group.py", line 30, in check_test_cnt
    for schema in schemas:
  File "/home/runner/.cache/pre-commit/repov8wo5h41/py_env-python3/lib/python3.10/site-packages/pre_commit_dbt/utils.py", line 2[35](https://github.com/cityblock/data-platform/actions/runs/4255882670/jobs/7404092720#step:10:36), in get_source_schemas
    for source in schema.get("sources", []):
AttributeError: 'str' object has no attribute 'get'

By restoring the types_or to the appropriate value, the hook correctly skips SQL files that are passed in.

[katieclaiborne]

@ssassi, would you be able to take a look at this fix?

Thanks to my teammate @eve-johns for identifying the issue!

[BAntonellini]

@ssassi, would you be able to take a look at this fix?

Thanks to my teammate @eve-johns for identifying the issue!

@katieclaiborne I agree with this fix, there is no point in checking if tests exist in SQL files, for the main reason that sources in dbt, alongside it's tests, are defined in YMLs.

[katieclaiborne]

I agree with this fix, there is no point in checking if tests exist in SQL files, for the main reason that sources in dbt, alongside it's tests, are defined in YMLs.

Thank you, Bruno!

[katieclaiborne]

Any news on an upcoming release?

[BAntonellini]

@

Any news on an upcoming release?

We've already drafted the content of the future 1.1 release, but will wait for a new service that is in merge process to complete and publish it.

[katieclaiborne]

We've already drafted the content of the future 1.1 release, but will wait for a new service that is in merge process to complete and publish it.

Amazing! Thanks for all your work.