-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check source has tests by group #91
Add check source has tests by group #91
Conversation
Currently unsure how to interpret the pytest failures. |
I think we need to also write a test file for this. |
Hi @ssassi, could you help us move this one along? |
Thanks @ashleemtib. @BAntonellini will take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Been testing locally using different PASS and FAIL expectancies, and everything is correct
Thanks, Bruno and Sebastián! Are you all planning to cut a new release for the package any time soon? We're updating the |
Solution for issue: #75
Added check_source_has_tests_by_group.py for a new hook that checks if a source has one or more tests within a test group. This hook enables searching of multiple types of tests on sources using OR logic, where any of the tests configured in the .yaml will cause the pre-commit check to pass.
This can be configured in the .pre-commit-config.yaml like so:
We tested this by running
pre-commit run check-source-has-tests-by-group
on a source with no uniqueness tests which proved failures, and then added a unique combination of columns test to the same source to prove passing.