Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement 'check has meta keys' for all meta-supported dbt objects #181

Conversation

BAntonellini
Copy link
Collaborator

No description provided.

@BAntonellini BAntonellini changed the title Dcv 2214 implement check xxx has meta keys for all meta supported dbt objects implement 'check has meta keys' for all meta-supported dbt objects Jan 30, 2024
@BAntonellini BAntonellini marked this pull request as ready for review January 30, 2024 19:55
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024

Codecov Report

Attention: Patch coverage is 78.10219% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 96.91%. Comparing base (783ceed) to head (0edce0a).
Report is 2 commits behind head on main.

Files Patch % Lines
dbt_checkpoint/utils.py 47.16% 28 Missing ⚠️
dbt_checkpoint/check_source_has_meta_keys.py 50.00% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##           main     #181       +/-   ##
=========================================
+ Coverage      0   96.91%   +96.91%     
=========================================
  Files         0       55       +55     
  Lines         0     2592     +2592     
  Branches      0      349      +349     
=========================================
+ Hits          0     2512     +2512     
- Misses        0       59       +59     
- Partials      0       21       +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ronak-datatonic ronak-datatonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. You could potentially define the loop in the functions "has_meta_key" in utils file

@BAntonellini BAntonellini requested review from ronak-datatonic and removed request for alfredodimassimo March 4, 2024 14:26
Copy link
Contributor

@ronak-datatonic ronak-datatonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BAntonellini BAntonellini merged commit 35375de into main Mar 6, 2024
7 checks passed
@BAntonellini BAntonellini deleted the DCV-2214-implement-check-xxx-has-meta-keys-for-all-meta-supported-dbt-objects branch March 6, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants